On Sat, Jan 09, 2016 at 12:05:10AM -0600, J Raynor wrote: > I got your email after I had sent in my patch. Should my patch be > reworked to include the vasprintf implementation from libnbcompat? > Or is the implementation in the patch ok? The nbcompat implementation is better, it avoids running the formatting twice for common shortish cases and it handles the potential missing va_copy better. Joerg