On Mon, Feb 04, 2008 at 07:02:53PM +0200, Arto Huusko wrote: > David Laight wrote: > >On Sat, Feb 02, 2008 at 11:54:13AM +0000, David Laight wrote: > >>I'll commit some changes that should be ok. > > > >Changes committed - hope they actually work :-) > > No, they don't. With your changes ktrace still shows: > > 746 1 skype CALL fcntl64(0x11,6,0xfddfe7e4) > 746 1 skype RET fcntl64 -1 errno -22 Invalid argument > > I think your changes fixed only F_[GS]ETLK64 commands, but left > F_[GS]ETLK broken when called with fcntl64. You need to handle > F_[GS]ETLK in both linux32_sys_fcntl and linux32_sys_fcntl64. Ah, ok, I really wasn't sure about the relation between the fcntl calls and the F_xxETLKnn commands. Something make me think that the 64bit (file offset) locking functions would be the only ones that came through fcntl64(). David -- David Laight: david%l8s.co.uk@localhost