On Thu, Nov 04, 2021 at 06:17:20PM -0700, Alistair Crooks wrote: > I think you're misreading the diff - it will only wrap if the minimum size > is 0xffffffff, which is...ummm...highly unlikely (it's defined to be 0 > right now, the type is unsigned) I'm not so much worried about the constant, but the right hand size. Without looking at the types, I can't be sure that "context->pwdlen + 1" doesn't overflow or that "context->m_cost - 1" can't underflow. Much easier and safer to just use a type cast... Joerg