bpo-21600: Fix `mock.patch.dict` to be stopped with `mock.patch.stopall` #17606

As the function was not registering in the active patches, the mocks
started by mock.patch.dict were not being stopped when
mock.patch.stopall was being called.

https://bugs.python.org/issue21600

Either we can have self._active_patches to add to stopall to stop patches with patch.dict or add to already active patches.

LGTM. Thanks Mario :)

Nov	DEC	Jan
	15
2018	2019	2020

Learn & contribute

Connect with others

Sponsor python/cpython

python/cpython

Join GitHub today

bpo-21600: Fix `mock.patch.dict` to be stopped with `mock.patch.stopall` #17606

bpo-21600: Fix `mock.patch.dict` to be stopped with `mock.patch.stopall` #17606

Conversation

mariocj89 commented Dec 14, 2019 • edited by bedevere-bot

tirkarthi left a comment

tirkarthi left a comment

mariocj89 commented Dec 14, 2019 •

edited by bedevere-bot