The Wayback Machine - http://web.archive.org/web/20201103025548/https://github.com/gvashishtha/machinelearning/pull/2
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merging latest questions #2

Merged
merged 10 commits into from Dec 2, 2019
Merged

merging latest questions #2

merged 10 commits into from Dec 2, 2019

Conversation

@gvashishtha
Copy link
Owner

@gvashishtha gvashishtha commented Dec 2, 2019

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.
codemzs and others added 10 commits Nov 21, 2019
…net#4490)

* Ignore hidden columns in AutoML schema checks of validation data
 Found that linux has different order for files being read in than
Windows in order to maintain values, using sort to remove this
discrepency between linux and other OSs

* remove special handling for nix.

* Found special handling of Nix in AutoML as well, now fixed. Also addressed typos.

* use short link to same dataset.
…r. (dotnet#4479)

* Ensure BufferBlocks are completed and empty in RowShufflingTransformer.

If BufferBlock doesn't get completed and drained of its items, it will have non-completed Tasks. When debugging in VS, this will appear to be a memory leak because VS adds all running Tasks to a static Dictionary, and then removes them when the Task is complete. If the Task doesn't get completed, it won't be removed from the Dictionary - thus it looks like a leak.

Note there is no leak when the VS Debugger isn't attached because the non-completed Tasks don't get added to the static Dictionary.

Fix dotnet#4399
* regression trainers export to onnx changes

* Capitalize test
…4462)

* Added onnx export support for several multiclass classifiers

* Separated LightGBM tests for 64-bit and updated baseline for another test

* Fixed bad merge
* Update KeyDataViewType API docs

* Update keyOrdinality description

* Refine addKeyValueAnnotationsAsText definition

* Removed duplicate line
* Revert "Disable tests on macOS that depend on GDI+ library. (dotnet#4492)"
…s from disk (dotnet#4485)

* Changed ComponentCatalog so it would use the most public "initter"
* Changed the visibility of several constructors and create methods so to choose the correct initter when loading models from disk
@gvashishtha gvashishtha merged commit 5c53ac6 into gvashishtha:master Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants
You can’t perform that action at this time.