The Wayback Machine - http://web.archive.org/web/20200617131929/https://github.com/bramp/js-sequence-diagrams/issues/176
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add features for notes and groups #176

Open
J-Wass opened this issue May 25, 2017 · 1 comment
Open

Add features for notes and groups #176

J-Wass opened this issue May 25, 2017 · 1 comment
Labels

Comments

@J-Wass
Copy link

@J-Wass J-Wass commented May 25, 2017

Notes should be able to extend across more than two participants.

Note over A,B,C: This is a long note!

Also, it would be really useful to create graphical groups around arrows, similar to 'opt's in web sequence diagrams.

Group Handshake
A->B: Send PacketRequest
B->A: Send PacketResponse
EndGroup

Finally, for when web sequences grow too big, it would nice to have the ability to collapse these groups to save both vertical and horizontal space.

CollapsibleGroup ReadDB
A->B: Send SQLQuery
B->A: Send DataSet
EndGroup
@bramp
Copy link
Owner

@bramp bramp commented May 25, 2017

ETOOMANYFEATUREREQUESTS

  1. You can already place notes over multiple participants, for example:
A->B: 1
B->C: 2
Note over A,C: This will cover lines A, B and C.

However, if you didn't know the order of the participants, I could see how you may not know that B was in the middle of C. So I think it might be far to allow A,B,C and ensure it covers all of them.

  1. Yes opts would be cool, and there is already a feature request for them #160

  2. Sounds a reasonable idea, but right now the generated SVGs are not interactive, but could be. Sounds low priority right now.

I welcome patches if you feel up to adding any of these features.

@bramp bramp added the enhancement label May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.