The Wayback Machine - http://web.archive.org/web/20201002041223/https://github.com/slackapi/hubot-slack/pull/374
Skip to content

/ hubot-slack

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codecov #374

Merged
merged 6 commits into from Nov 10, 2016
Merged

Codecov #374

merged 6 commits into from Nov 10, 2016

Conversation

@DEGoodmanWilson
Copy link

@DEGoodmanWilson DEGoodmanWilson commented Nov 10, 2016

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
  • I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
  • I've written tests to cover the new code and functionality included in this PR.
  • I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary

Move to Codecov from Coveralls
Don Goodman-Wilson added 6 commits Nov 10, 2016
Don Goodman-Wilson
Codecov!
3cc0612
Don Goodman-Wilson
Temp
a9acfb7
Don Goodman-Wilson
Nevermind!
Loading status checks…
45ea80e
Don Goodman-Wilson
Add codecov to ignore wrapper file
Loading status checks…
488d09e
Don Goodman-Wilson
Codecov badge
Loading status checks…
221f953
Don Goodman-Wilson
Ignore the tests folder
Loading status checks…
f514336
@codecov-io
Copy link

@codecov-io codecov-io commented Nov 10, 2016 •
edited

Current coverage is 84.14% (diff: 100%)

No coverage report found for master at 8fce5a2.

Powered by Codecov. Last update 8fce5a2...f514336
@aoberoi
aoberoi approved these changes Nov 10, 2016
View changes
@DEGoodmanWilson DEGoodmanWilson merged commit e182c95 into master Nov 10, 2016
3 checks passed
3 checks passed
codecov/patch Coverage not affected.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@DEGoodmanWilson DEGoodmanWilson deleted the codecov branch Nov 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoberoi aoberoi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@DEGoodmanWilson @codecov-io @aoberoi
You can’t perform that action at this time.