The Wayback Machine - http://web.archive.org/web/20210124110503/https://github.com/react-component/steps/pull/110
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use father & rc-util #110

Merged
merged 10 commits into from Jun 1, 2020
Merged

chore: Use father & rc-util #110

merged 10 commits into from Jun 1, 2020

Conversation

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Jun 1, 2020

zombieJ added 7 commits Jun 1, 2020
@lgtm-com
Copy link

@lgtm-com lgtm-com bot commented Jun 1, 2020

This pull request introduces 1 alert when merging 24a14a4 into 0606332 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class
@@ -5,5 +5,6 @@ module.exports = {
rules: {
...base.rules,
'arrow-parens': 0,
'react/no-find-dom-node': 0,

This comment has been minimized.

@afc163

afc163 Jun 1, 2020
Member

findDOMNode 干掉了这个规则也可以留着了吧。

This comment has been minimized.

@zombieJ

zombieJ Jun 1, 2020
Author Member

嗯,IE 9 支持去掉后清爽了不少。

zombieJ added 2 commits Jun 1, 2020
@codecov
Copy link

@codecov codecov bot commented Jun 1, 2020

Codecov Report

No coverage uploaded for pull request base (master@0606332). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #110   +/-   ##
=========================================
  Coverage          ?   91.78%           
=========================================
  Files             ?        2           
  Lines             ?       73           
  Branches          ?       25           
=========================================
  Hits              ?       67           
  Misses            ?        6           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0606332...d9b4cc2. Read the comment docs.

@lgtm-com
Copy link

@lgtm-com lgtm-com bot commented Jun 1, 2020

This pull request introduces 1 alert when merging d9b4cc2 into 0606332 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class
@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Jun 1, 2020

done. 发个大版本。

@zombieJ zombieJ merged commit 7f35f9d into master Jun 1, 2020
6 checks passed
6 checks passed
LGTM analysis: JavaScript 1 new alert
Details
WIP Ready for review
Details
codecov/patch Coverage not affected
Details
codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@delete-merged-branch delete-merged-branch bot deleted the father branch Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants