Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMemory channel doesn't clear queues on close #1147
Open
Comments
|
failing test case with a fix? |
|
@auvipy There is no fix because I don't know what the expected behaviour is.
It is crucial to decide on the behaviour wanted before commencing implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
kombu/kombu/transport/memory.py
Line 59 in cbd327d
queue.empty()doesn't empty the queue - it returns a boolean stating whether the queue is empty. In order to clear a queue (without touching the internals), one has to pop from it until it's empty.It remains a question if clearing should take place at all and whether the queues should be channel-scoped or transport-scoped. There's definitely a need to be able to clear the queues between tests.