The Wayback Machine - http://web.archive.org/web/20200915125615/https://github.com/drahnr/cargo-spellcheck/pull/70
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/README: fix installation instruction for macOS with hunspell support #70

Merged
merged 1 commit into from Jul 10, 2020

Conversation

@rhysd
Copy link
Contributor

rhysd commented Jul 10, 2020

What does this PR accomplish?

  • Bug Fix
  • Feature
  • Documentation

closes no issue.

Changes proposed by this PR:

I'm using macOS 10.14 and tried to install this tool by cargo install but I got 'llvm-config is not found' error on building hunspell-sys.

brew install llvm does not install LLVM tools into $PATH directory such as /usr/local/bin because they confuse LLVM toolchain Xcode installs by default. They are put in /usr/local/opt/llvm/bin. llvm-config is put in the directory and the path needs to be populated with $LLVM_CONFIG_PATH environment variable.

Notes to reviewer:

Nothing.

@drahnr
drahnr approved these changes Jul 10, 2020
@drahnr drahnr merged commit 22c3464 into drahnr:master Jul 10, 2020
4 checks passed
4 checks passed
concourse-ci/compile Concourse CI build success
Details
concourse-ci/meta-check Concourse CI build success
Details
concourse-ci/run-check Concourse CI build success
Details
concourse-ci/unit-tests Concourse CI build success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.