Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEmbedded YouTube videos cannot start at a certain time using "?start=..." #328
Comments
Obayanju
added a commit
to Obayanju/writefreely
that referenced
this issue
Aug 7, 2020
This uses go's html and url parser plus regex, instead of using only a single regex for simplicity sake. A single regex expression might be error prone, for example, when trying to matching html entities. Fixes writeas#328
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
This code https://github.com/writeas/writefreely/blob/develop/postrender.go#L100-L102 (which is states the intention is to remove
autoplay) makes it so that I cannot have YouTube videos start at a precise moment using?start=....Expected behavior
It should just remove the
autoplayquery parameter if that is the intention. Although I don't understand why that would happen on the blog page. It seems like something you would only want to remove on blog previews when there could be many annoying "autoplay"s triggered.Application configuration
Version or last commit: 4570511