Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Fix double AllowObservable for SVGAttributes #125
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #125 +/- ##
=======================================
Coverage 97.13% 97.13%
=======================================
Files 20 20
Lines 558 558
=======================================
Hits 542 542
Misses 16 16 Continue to review full report at Codecov.
|
|
Looks like something's wrong with codecov setup. This PR doesn't change any source files tracked by codecov, nor I can see any informative message from codecov, could you please help? |
|
Ah, seems everything's ok now, I just needed to merge |
|
sorry for the late review, thanks for the contrib! LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Hi!
This PR contains the following changes:
.ideadirectory to.gitignore- this is project configuration directory specific to WebStorm IDESVGAttributesso that it doesn't callAllowObservabletwice for properties inherited fromHTMLAttributeswhich callsAllowObservableitself. InsteadSVGAttributesshould extend plain_HTMLAttributes