Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate eslint to v7.0.0 #4281
Update eslint to v7.0.0 #4281
Comments
vansergen
mentioned this issue
|
Hi @vansergen . So I think it's good, with some changes:
Either way (original or 2 above), we need to determine what the plan of landing will actually be, as it seems like the suggestion here is requiring massive changes to the source code, which I would presume would make a lot of our in progress PRs no longer mergeable, right? That would throw a large wrench into the final efforts of 5.0, so may be worth waiting to perform this until after 5.0 is first release, maybe? |
|
@dougwilson What is the point to keep support of Node <10 (#2755 (comment)) on If you want to move forward to StandardJS, maybe we should add eslint-config-standard to |
None, but if we can possibly target
Yep |
|
If we are going to reformat all the code in one go, we'll definitely do that in it's own PR. If we want to do that at some point, we could, but past conversations I'm aware of have decided to only apply formatting changes to the pieces of code touched in each commit, to avoid overwriting the entire blame history of the project. |
|
Not super relevant but version 15 of eslint-config-standard will be the one to support ESLint 7, my plan is to release it in the coming days: https://github.com/standard/eslint-config-standard/issues/171 Still, I think that we should use some tool to only lint changed lines of code, since otherwise we will break merging between e.g. 5.x and 4.x, and loose all blame information. |

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

@dougwilson Let's update the devDependency
eslintto v7.0.0 (on the5.0branch).It would involve:
package.json6accaf4eslint --fix100c2bdWhat do you think?