The Wayback Machine - http://web.archive.org/web/20201107154613/https://github.com/expressjs/express/issues/4281
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint to v7.0.0 #4281

Open
vansergen opened this issue May 15, 2020 · 5 comments
Open

Update eslint to v7.0.0 #4281

vansergen opened this issue May 15, 2020 · 5 comments
Labels

Comments

@vansergen
Copy link

@vansergen vansergen commented May 15, 2020

@dougwilson Let's update the devDependency eslint to v7.0.0 (on the 5.0 branch).

It would involve:

What do you think?

@dougwilson
Copy link
Member

@dougwilson dougwilson commented May 15, 2020

Hi @vansergen . So I think it's good, with some changes:

  1. There is no need to drop Node.js support for a dev dependency; the CI scripts should just be updated to use that on the needed Node.js versions.
  2. The goal of this project is to change everything to StandardJS format. If there is going to be massive changes to the source (as it seems from the second commit above), we should just change to StandardJS fully at this point.

Either way (original or 2 above), we need to determine what the plan of landing will actually be, as it seems like the suggestion here is requiring massive changes to the source code, which I would presume would make a lot of our in progress PRs no longer mergeable, right? That would throw a large wrench into the final efforts of 5.0, so may be worth waiting to perform this until after 5.0 is first release, maybe?

@vansergen
Copy link
Author

@vansergen vansergen commented May 16, 2020

@dougwilson What is the point to keep support of Node <10 (#2755 (comment)) on 5.0 branch?

If you want to move forward to StandardJS, maybe we should add eslint-config-standard to devDependencies?

@dougwilson
Copy link
Member

@dougwilson dougwilson commented May 16, 2020

What is the point to keep support of Node <10 (#2755 (comment)) on 5.0 branch?

None, but if we can possibly target master, that would be best, as we will need to keep merging 4.x into 5.0 over the next year as we support it, so if these changes are going to break mergeability, we should have a clear reason why it cannot go into master (4.x).

If you want to move forward to StandardJS, maybe we should add eslint-config-standard to devDependencies?

Yep

@jonchurch
Copy link
Member

@jonchurch jonchurch commented May 16, 2020

If we are going to reformat all the code in one go, we'll definitely do that in it's own PR. If we want to do that at some point, we could, but past conversations I'm aware of have decided to only apply formatting changes to the pieces of code touched in each commit, to avoid overwriting the entire blame history of the project.

@LinusU
Copy link
Member

@LinusU LinusU commented May 18, 2020

Not super relevant but version 15 of eslint-config-standard will be the one to support ESLint 7, my plan is to release it in the coming days: https://github.com/standard/eslint-config-standard/issues/171

Still, I think that we should use some tool to only lint changed lines of code, since otherwise we will break merging between e.g. 5.x and 4.x, and loose all blame information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.