Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd ubisoft.com and ubi.com to equivialent domains list #447
Conversation
|
@kspearrin Any particular reason why this store is super hardcoded instead of loaded from file (JSON?) |
|
@Lillecarl Not really. I do have a backlog item to work on converting this to a static JSON file fetched from the apps that can be hosted on our CDN since that does make more since. |
|
@kspearrin If you go that route, don't forget to do some sort of integrity check to limit the effectiveness of MITM attacks. Erroneous equivalent domains can be a security issue. Once in a while it will be a good idea to revalidate all equivalent domains as well. |
|
@setyb https should solve this, my thinking was honestly just adding a json to the build instead of hardcoding it. If the json is distributed over HTTP I'd say it should be signed by a bitwarden cert though for that security indeed. |
|
|

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

Set enum to 76 instead of 75 to allow room for existing pull request for oneprovider.com