The Wayback Machine - http://web.archive.org/web/20201006050349/https://github.com/bitwarden/server/pull/447
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ubisoft.com and ubi.com to equivialent domains list #447

Open
wants to merge 2 commits into
base: master
from

Conversation

@setyb
Copy link
Contributor

@setyb setyb commented Feb 28, 2019

Set enum to 76 instead of 75 to allow room for existing pull request for oneprovider.com

setyb added 2 commits Feb 27, 2019
Used value of 76 since a pending pull request  already is using 75.
@Lillecarl
Copy link

@Lillecarl Lillecarl commented Mar 10, 2019

@kspearrin Any particular reason why this store is super hardcoded instead of loaded from file (JSON?)

@kspearrin
Copy link
Collaborator

@kspearrin kspearrin commented Mar 11, 2019

@Lillecarl Not really. I do have a backlog item to work on converting this to a static JSON file fetched from the apps that can be hosted on our CDN since that does make more since.

@setyb
Copy link
Contributor Author

@setyb setyb commented Mar 11, 2019

@kspearrin If you go that route, don't forget to do some sort of integrity check to limit the effectiveness of MITM attacks. Erroneous equivalent domains can be a security issue.

Once in a while it will be a good idea to revalidate all equivalent domains as well.

@Lillecarl
Copy link

@Lillecarl Lillecarl commented Mar 11, 2019

@setyb https should solve this, my thinking was honestly just adding a json to the build instead of hardcoding it.

If the json is distributed over HTTP I'd say it should be signed by a bitwarden cert though for that security indeed.

@CLAassistant
Copy link

@CLAassistant CLAassistant commented Mar 7, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.