The Wayback Machine - http://web.archive.org/web/20200905112104/https://github.com/atom/github/issues/1905
Skip to content

/ github

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consistently use `Timeago` component to humanize timestamps #1905

Open
annthurium opened this issue Jan 11, 2019 · 2 comments
Open

consistently use `Timeago` component to humanize timestamps #1905

annthurium opened this issue Jan 11, 2019 · 2 comments
Assignees
@annthurium
Labels
code-cleanup 🔧 good first issue

Comments

@annthurium
Copy link
Contributor

@annthurium annthurium commented Jan 11, 2019

We have this sweet Timeago component that humanizes a timestamp, and then keeps that data up to date.

I did not know about Timeago, when we were making the CommitDetailView and the PullRequestCommitView. It would be good to make those components use Timeago, and also see if there's anywhere else that needs to be cleaned up.
@annthurium annthurium changed the title consistently use `Timeago` component to humanize timestaps consistently use `Timeago` component to humanize timestamps Jan 12, 2019
@annthurium annthurium self-assigned this Feb 27, 2019
@MiguelSilva96
Copy link

@MiguelSilva96 MiguelSilva96 commented Jun 20, 2019

Hi, I would like to start contributing and this seems like a good issue to start 😃 Would it be ok if I tried to have a look at it? The two views that don't use Timeago referenced in the description seem pretty straight forward to fix but looking for other files is the tricky part.
@wadethestealth
Copy link
Contributor

@wadethestealth wadethestealth commented Nov 8, 2019

@MiguelSilva96 Just go for it. Its better to open PR's on this repo rather than comment inside issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annthurium annthurium

Labels
code-cleanup 🔧 good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@annthurium @wadethestealth @MiguelSilva96
You can’t perform that action at this time.