Fix parsing of unusual trailing expressions separated by whitespace #1125

MaxGraey · 2020-02-26T18:12:36Z

The issue described in next examples:

function add(y: i32): i32 {
  let x = y 234;
  return x + y;
}

function foo(): i32 {
  return 123 456;
}

interpreted currently as:

function add(y: i32): i32 {
  let x = y;
  234; // skip as unreachable
  return x + y;
}

function foo(): i32 {
  return 123;
  456; // skip as unreachable
}

And normally compiled, but should be compiler error.

MaxGraey · 2020-07-03T20:41:40Z

Btw it should expect , after walk-through spaces and come across to new token which not a comma or semicolon in such contexts

MaxGraey added enhancement help wanted labels Feb 26, 2020

MaxGraey changed the title ~~[Parser] Interpret tail expressions as unrechables~~ [Parser] Interpret tail expressions divided via space as unrechables Feb 26, 2020

dcodeIO added bug and removed enhancement labels May 28, 2020

dcodeIO changed the title ~~[Parser] Interpret tail expressions divided via space as unrechables~~ Fix parsing of unusual trailing expressions separated by whitespace May 28, 2020

dcodeIO added good first issue and removed help wanted labels May 28, 2020

Jul	AUG	Sep
	24
2019	2020	2021

AssemblyScript / assemblyscript

Fix parsing of unusual trailing expressions separated by whitespace #1125

Fix parsing of unusual trailing expressions separated by whitespace #1125

MaxGraey commented Feb 26, 2020 •

edited

MaxGraey commented Jul 3, 2020 •

edited

AssemblyScript / assemblyscript

Sponsor AssemblyScript/assemblyscript

Join GitHub today

Fix parsing of unusual trailing expressions separated by whitespace #1125

Fix parsing of unusual trailing expressions separated by whitespace #1125

Comments

MaxGraey commented Feb 26, 2020 • edited

MaxGraey commented Jul 3, 2020 • edited

MaxGraey commented Feb 26, 2020 •

edited

MaxGraey commented Jul 3, 2020 •

edited