The Wayback Machine - http://web.archive.org/web/20200914101845/https://github.com/mourner/rbush-knn/pull/19
Skip to content

/ rbush-knn

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: convert rbush-knn to es6 module #19

Merged
merged 1 commit into from Aug 3, 2020
Merged

refactor: convert rbush-knn to es6 module #19

merged 1 commit into from Aug 3, 2020
+42 −26

Conversation

@chimurai
Copy link
Contributor

chimurai commented Aug 2, 2020 •
edited

TL;DR
Convert rbush-knn to es6 module.

Would be nice to convert rbush-knn to es6, since rbush already has been converted to es6 for quite a while. (mourner/rbush#89)

This is also fixes #18 .

Used the same setup for npm build as in https://github.com/mourner/rbush

Please let me know if you have any questions or concerns.
@chimurai
refactor: convert rbush-knn to es6 module
eef7781
@mourner
mourner approved these changes Aug 3, 2020
View changes
@mourner
Copy link
Owner

mourner commented Aug 3, 2020

All looking good, thank you!
@mourner mourner merged commit cd195a3 into mourner:master Aug 3, 2020
@sfreytag
Copy link

sfreytag commented Aug 3, 2020

Thanks! I had been meaning to give this a go but you beat me to it. I will merge the new ES6 module into my project to verify #18 is fixed for me, but i am sure it will be.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Queue is not a constructor
3 participants
@chimurai @mourner @sfreytag
You can’t perform that action at this time.