The Wayback Machine - http://web.archive.org/web/20201130145002/https://github.com/kriasoft/react-starter-kit/pull/1413
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Babel to v7 #1413

Merged
merged 1 commit into from Oct 2, 2017
Merged

Update Babel to v7 #1413

merged 1 commit into from Oct 2, 2017

Conversation

@frenzzy
Copy link
Member

@frenzzy frenzzy commented Sep 29, 2017

No description provided.

@frenzzy frenzzy force-pushed the frenzzy:babel-7 branch 2 times, most recently from 21a474b to 4b907e5 Sep 29, 2017
@frenzzy frenzzy force-pushed the frenzzy:babel-7 branch from 4b907e5 to d7545ce Oct 2, 2017
@frenzzy frenzzy merged commit 08d44d0 into kriasoft:master Oct 2, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@frenzzy frenzzy deleted the frenzzy:babel-7 branch Oct 2, 2017
...(isDebug ? ['transform-react-jsx-self'] : []),
// Treat React JSX elements as value types and hoist them to the highest scope
// https://github.com/babel/babel/tree/master/packages/babel-plugin-transform-react-constant-elements
...(isDebug ? ['transform-react-constant-elements'] : []),

This comment has been minimized.

@plemarquand

plemarquand Oct 5, 2017

@frenzzy Don't you want to include these plugins if it's not a release build?

This comment has been minimized.

@frenzzy

frenzzy Oct 5, 2017
Author Member

Nope, they make no sense in debug mode, just increase compilation time and make debugging harder.

This comment has been minimized.

@plemarquand

plemarquand Oct 6, 2017

Wow that was a brain fart, yesterday was a long day...

buildbreakdo added a commit to buildbreakdo/react-starter-kit that referenced this pull request Dec 3, 2017
* 'master' of github.com:kriasoft/react-starter-kit: (68 commits)
  Format Markdown (.md) files by Prettier (kriasoft#1461)
  Move prettier options to a separate file for editor or ide plugin
  Update dependencies; bump react to v16.1.1
  Update Babel to v7.0.0-beta.32 (kriasoft#1452)
  Update universal-router and react-error-overlay
  Use babel react optimization plugins for production instead of development
  Bump babel-preset-env
  Update dependencies; fix eslint warnings
  Update yarn.lock
  Add tools to babel-loader include
  Fore all Babel transforms in release mode only for UglifyJS2
  Update babel-plugin-transform-react-* to v7
  Fix babel ignore configuration
  Use webpack-hot-middleware api instead of query string
  Improve developer experience; update react-error-overlay (kriasoft#1421)
  Update React to v16 (kriasoft#1417)
  Update server-side dependencies
  Update Babel to v7 (kriasoft#1413)
  Remove unused mocha configs and dependencies
  Update PostCSS related dependencies, remove unused
  ...
n-parasochka pushed a commit to n-parasochka/react-starter-kit that referenced this pull request Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.