Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix ESLint warnings #192
Fix ESLint warnings #192
Comments
|
I can help if you can provide more info. |
|
@rajpatel507 assuming you have Node.js v6+ and Yarn installed, when you run https://github.com/airbnb/javascript |
|
@rajpatel507 you got what you needed and making progress? Checking in because I am interested. Thanks. |
|
@ericlau-solid I am getting around 40 errors and 2 warnings, is it normal or i am missing something? |
|
@rajpatel507 Fixing the errors and warnings is the ask. You know you are done when the package still works and you get no errors and warnings. |
|
@ericlau-solid some errors indicating that package is not in package.json dependency and still it is used but we have all dependency there in package.json, this is usally when eslint is not finding package.json file in source .I need to investigate why .eslintrc file is not pointing to package.json |
|
@rajpatel507 there are multiple package.json files. when running eslint, it only looks at the package.json closest to the file in question. All package.json in sub-folders need to have dependencies object correctly set up. |
|
Is there any status on this? |
|
@drmanitoba not able to figuring out why error is there even if package is there in dev dependency of package.json |
|
@rajpatel507 just add |
|
@frenzzy Thanks for suggestion, I have added @koistya should I remove all other warning or create pull request for this changes only? |
|
This issue about fixing all eslint errors and warnings |
|
I think you can just add inline comment to make it clear for developers that this was done deliberately and not by mistake, for example: <div
// eslint-disable-next-line react/no-danger
dangerouslySetInnerHTML={{ __html: html }}
/>ref react/no-danger |
|
I have created pull request for same. |
|
@rajpatel507 Awesome! I just reviewed it #199 |



Is anyone willing to help? Run
yarn lintin a terminal window. Seepackage.json/eslintConfig.