Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Housekeeping of auth backend & Update Security doc #8071
Conversation
- All authentication backends in `airflow/contrib/auth` are base on the `user` model which has already been removed earlier (#4577 (comment)) - Security related documentation is out-dated, especially the LDAP and OAuth integration sections. It still directs user to the configuration of "old" web UI which has already been removed in master branch.
|
Hi @kaxil @potiuk @zhongjiajie , this is the change I mentioned in our earlier discussion #4577 (comment) . I will raise another PR to address similar issue (out-dated documentation) for 1-10-x branch. |
|
Is the code really out-dated :)? I did not realise that :) |
|
@potiuk It will be great if you can help take another further look and confirm. The main reasoning is all of the |
|
Makes sense. Looks good. |
apache#8071 removed Auth Backend but didn't remove some functions used by those method.
airflow/contrib/authare base on theusermodel which has already been removed earlier (#4577)Issue link: WILL BE INSERTED BY boring-cyborg
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.