The Wayback Machine - http://web.archive.org/web/20200725003719/https://github.com/facebook/react/pull/17971
Skip to content

/ react

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Suspense priority warning #17971

Merged
merged 2 commits into from Feb 4, 2020
Merged

Remove Suspense priority warning #17971

merged 2 commits into from Feb 4, 2020
+29 −166

Conversation

@gaearon
Copy link
Member

gaearon commented Feb 4, 2020

We know there are at least two bugs there:

  • It only checks the first Hook.
  • There is a DEV-only infinite loop in the class codepath because update.next can be update.

We also haven't managed to enable it yet on WWW.
Let's remove for now and revisit closer to the release.
@gaearon gaearon requested review from lunaruan, acdlite and sebmarkbage Feb 4, 2020
@gaearon
Remove Suspense priority warning
Loading status checks…
fd9fadd
@gaearon gaearon force-pushed the gaearon:pri-warn branch from 26f85a4 to fd9fadd Feb 4, 2020
@gaearon
Fix tests
Loading status checks…
57dca4e
@gaearon gaearon force-pushed the gaearon:pri-warn branch from 497b2f6 to 57dca4e Feb 4, 2020
@sizebot
Copy link

sizebot commented Feb 4, 2020

Warnings
⚠️ Could not find build artifacts for base commit: 812277d

Size changes (experimental)

Generated by 🚫 dangerJS against 57dca4e

@sizebot
Copy link

sizebot commented Feb 4, 2020

Warnings
⚠️ Could not find build artifacts for base commit: 812277d

Size changes (stable)

Generated by 🚫 dangerJS against 57dca4e

@codesandbox
Copy link

codesandbox bot commented Feb 4, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 57dca4e:

Sandbox Source
eloquent-dust-1nf1v Configuration
@acdlite
acdlite approved these changes Feb 4, 2020
View changes
@gaearon gaearon merged commit d6e08fe into facebook:master Feb 4, 2020
22 checks passed
22 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_devtools_and_process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: build_experimental Your tests passed on CircleCI!
Details
ci/circleci: flow Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint_build Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts Your tests passed on CircleCI!
Details
ci/circleci: process_artifacts_experimental Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: sizebot Your tests passed on CircleCI!
Details
ci/circleci: sizebot_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build Your tests passed on CircleCI!
Details
ci/circleci: test_build_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod Your tests passed on CircleCI!
Details
ci/circleci: test_build_prod_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_devtools Your tests passed on CircleCI!
Details
ci/circleci: test_dom_fixtures Your tests passed on CircleCI!
Details
ci/circleci: test_source Your tests passed on CircleCI!
Details
ci/circleci: test_source_experimental Your tests passed on CircleCI!
Details
ci/circleci: test_source_persistent Your tests passed on CircleCI!
Details
ci/circleci: test_source_prod Your tests passed on CircleCI!
Details
ci/codesandbox Building packages succeeded.
Details

@threepointone threepointone mentioned this pull request Feb 25, 2020

Merged

@yowainwright yowainwright mentioned this pull request Mar 6, 2020

Open

This was referenced Mar 6, 2020

Closed

Merged

Open

Merged

Merged

Merged

Merged

Open

Closed

Open

Merged

Merged

Merged

This was referenced Apr 23, 2020

Open

Merged

Closed

Open

Open

Open

Closed

Open

Open

Open

Merged

Open

This was referenced Apr 30, 2020

Open

Open

Open

Open

Open

Closed

@SeiyaTakahashi SeiyaTakahashi mentioned this pull request May 3, 2020

Merged

This was referenced May 4, 2020

Open

Open

Open

Merged

Merged

Open

Open

@HNaida HNaida mentioned this pull request May 6, 2020

Merged

This was referenced May 6, 2020

Open

Closed

Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acdlite acdlite

@sebmarkbage sebmarkbage

@lunaruan lunaruan

Assignees
No one assigned
Labels
CLA Signed React Core Team
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@gaearon @sizebot @acdlite @facebook-github-bot
You can’t perform that action at this time.