The Wayback Machine - http://web.archive.org/web/20201030093117/https://github.com/HelloZeroNet/ZeroNet/pull/2024
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PeerMessage support for Python 3 #2024

Open
wants to merge 2 commits into
base: py3
from

Conversation

@imachug
Copy link
Contributor

@imachug imachug commented May 19, 2019

I've ported PeerMessage to py3 recently. This has been tested (probably even more than py2 version -- I had to backport some fixes). Please merge this.

Main discussion: #1430 (please post not-py3-only issues there).

@imachug imachug force-pushed the imachug:peermessage-py3 branch from 03f7f02 to 28420c0 May 22, 2019
@imachug imachug force-pushed the imachug:peermessage-py3 branch from 28420c0 to 0a787a1 Jun 26, 2019
@imachug
Copy link
Contributor Author

@imachug imachug commented Jun 26, 2019

@HelloZeroNet I'm sorry for interrupting you again, but could you check this plugin please? I don't want to be aggressive, but it's been more than a year.

If you don't like the plugin idea for some reason, tell me, please. If you think it can be implemented better -- no problem, I'll understand you. If you think this plugin is not important enough to be included to the official repo -- ok, but why are StemPort and Dnschain plugins included then?

Nevertheless, can we stop just keeping silent? This plugin is used by many zites (including, but not limited to 0Play Game Center, z/place, KxoNetwork, StreamZ), and can be used to build more sites (I'm working on several right now).

There is an issue about including the plugin to the official repo (HelloZeroNet/Plugin-PeerMessage#4), 8 positive reactions on the original PR (#1430), 7 positive reactions on the original issue (#1425), 3 "Why is this not merged" comments from different people (#1430 (comment), #1430 (comment), #1430 (comment)). A total of 13 people (including me) support this plugin. I can even list them here: @AnthyG, @krixano, @filips123, @stbinan, @anoadragon453, @blurHY, @tangdou1, @HughIsaacs2, @DaniellMesquita, @imachug, @Thunder33345, @MisterX2000, @Zero-1729.

Looking forward to get the PR merged.

@DaniellMesquita
Copy link
Contributor

@DaniellMesquita DaniellMesquita commented Jun 26, 2019

up for this PR

@imachug imachug force-pushed the imachug:peermessage-py3 branch from 7bef3fc to b63197b Jul 1, 2019
@HelloZeroNet
Copy link
Owner

@HelloZeroNet HelloZeroNet commented Jul 4, 2019

I just started working on a plugin manager interface that will easily allow to add/enable/disable the plugins.

@imachug
Copy link
Contributor Author

@imachug imachug commented Jul 4, 2019

While this is great news of course, I'm still sure that this plugin is important enough to be included to the default distribution.

@AnthyG
Copy link

@AnthyG AnthyG commented Jul 4, 2019

I agree with @imachug.
This plugin is a great addition functionality wise, but that ofc doesn't mean it can't be disabled by default (I guess it would rather mean that it should be disabled by default).

@imachug imachug force-pushed the imachug:peermessage-py3 branch from b63197b to 3366652 Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.