Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd PeerMessage support for Python 3 #2024
Conversation
|
@HelloZeroNet I'm sorry for interrupting you again, but could you check this plugin please? I don't want to be aggressive, but it's been more than a year. If you don't like the plugin idea for some reason, tell me, please. If you think it can be implemented better -- no problem, I'll understand you. If you think this plugin is not important enough to be included to the official repo -- ok, but why are StemPort and Dnschain plugins included then? Nevertheless, can we stop just keeping silent? This plugin is used by many zites (including, but not limited to 0Play Game Center, z/place, KxoNetwork, StreamZ), and can be used to build more sites (I'm working on several right now). There is an issue about including the plugin to the official repo (HelloZeroNet/Plugin-PeerMessage#4), 8 positive reactions on the original PR (#1430), 7 positive reactions on the original issue (#1425), 3 "Why is this not merged" comments from different people (#1430 (comment), #1430 (comment), #1430 (comment)). A total of 13 people (including me) support this plugin. I can even list them here: @AnthyG, @krixano, @filips123, @stbinan, @anoadragon453, @blurHY, @tangdou1, @HughIsaacs2, @DaniellMesquita, @imachug, @Thunder33345, @MisterX2000, @Zero-1729. Looking forward to get the PR merged. |
|
up for this PR |
|
I just started working on a plugin manager interface that will easily allow to add/enable/disable the plugins. |
|
While this is great news of course, I'm still sure that this plugin is important enough to be included to the default distribution. |
|
I agree with @imachug. |

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

I've ported PeerMessage to py3 recently. This has been tested (probably even more than py2 version -- I had to backport some fixes). Please merge this.
Main discussion: #1430 (please post not-py3-only issues there).