Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upimprove LoggerCommand #920
Open
Conversation
core/src/main/java/com/taobao/arthas/core/command/logger/LoggerCommand.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/taobao/arthas/core/command/logger/LoggerCommand.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/taobao/arthas/core/command/logger/LoggerCommand.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/taobao/arthas/core/command/logger/LoggerCommand.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/taobao/arthas/core/command/logger/LoggerCommand.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/taobao/arthas/core/command/logger/LoggerCommand.java
Outdated
Show resolved
Hide resolved
qxo
force-pushed the
qxo:improve4logger
branch
2 times, most recently
from
6dc1bbd
to
eb9bb53
qxo
force-pushed the
qxo:improve4logger
branch
2 times, most recently
from
b5e915d
to
0c4fbf8
|
|
1. 重构level方法，返回第一个最合适的classloader对应LoggerTypes，默认情况基本不用-c参数，提高日志设置指令可重用度，提升可用性 根据应用环境的实际情况再调用具体实现类库更新日志级别，而不是之前的不管是否有log4j/logback/log4j分别各调用一次（不存在类库会在日志文件生成异常日志） 2. 增加-p参数，可根据类名来过滤classloader或loggerName 3. 日志级别设置时结果多加了各日志类库的对应的日志级别修改结果 同时输出对应classloader的hashCode,用于recheck: 用来在需要时确认设置的日志级别对应classloader和期望的是否一致
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
根据应用环境的实际情况再调用具体实现类库更新日志级别，而不是之前的不管是否有log4j/logback/log4j分别各调用一次（不存在类库会在日志文件生成异常日志）
同时输出对应classloader的hashCode,用于recheck: 用来在需要时确认设置的日志级别对应classloader和期望的是否一致