Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Icon request #185
Icon request #185
Comments
|
That's nice! I suggest you add the python 2 version, since it's much more stable. I should make the python 3 version more stable, though. |
|
Thank you! I myself have designed several good-looking logos, and if you'd like I can give feedback & offer suggestions. Speaking of stability, a while back I had an issue searching youtube with tboplayer where the search results would never show up. Are you aware of that bug? If not, never mind and don't worry about it. |
|
Sure, I appreciate the help on the icon! I am aware of this bug. The cause is that Youtube changed its search results page, so the script that was made to crawl it does not work anymore. I opened an issue reporting this problem today. This also happens in the python 2 version. |
|
Great! You know what, I could design the whole icon for you if you want. Just give me a rough idea of what it should look like. |
|
What does TBO stand for? |
|
Good question. Maybe @KenT2 can answer that. hehe |
|
Thompson Baiter Omxplayer. JBaiter wrote the original interface software. |
|
@heniotierra |
|
Well, yes, it can play Youtube, but it can also play all of the most popular streaming services (last time I checked), that's why I thought of not making this reference. But I loved the icon! And I guess the reference doesn't hurt.
True. Hey @KenT2 , would you have an opinion? |
|
@KenT2 @heniotierra Have we made a decision yet? |
|
I guess we can go with the red one. :) I think it draws more attention. |
|
OK. Attached is a zip file containing a bunch of sizes of your new icon. |
|
Thank YOU for your work! |
|
@Botspot please, send an email if you need anyhting specific from me to make TBOPlayer installer work on the store you're building. It's heniotster at gmail dot com. |
|
I sent you an email over a week ago. Have you seen it? |
|
Hi @Botspot ! Your email never arrived. |
|
Also, for transparency sake, I must say I'll dump the Python 3 version in favor of the Python 2 one. The reason for that being that OMXPlayer will be discontinued as can be seen in its github page, thus I don't think it's worth investing much in a Python 3 version. However, I should still fix and maintain the Python 2 version as long as OMXPlayer still works and has users. The efforts put into OMXPlayer will be put on developing VLC. |
|
The Pure Data thing appeared in the menu at the same time I installed TBOPlayer. I would assume one of your APT dependencies managed to install it. Looking forward to the icon change. :) OK. Well I've already taken your suggestion and am using the Py2 version. |
|
Maybe it's some dependency doing that, yeah. Can you try to investigate that button? If it's showing in the menu, it's most probably present in the path I mentioned. By looking as its code through the text editor you should be able to know its source. You can paste the content here too, so I can take a look. |
|
I can check it later, but it did go away after I ran:
|
|
Okay, I found it. |
|
And this is the contents of
|
|
Ok, thanks. I'll look into that. |
|
Yep - looks to be a dependency problem.
|
|
BINGO! I'll let the apt output speak for itself:
(I found that the package |
|
An update: using |
|
That's nice @Botspot ! Thank you again for your help! :) |
|
@Botspot , will you need any icon size different 24x24? If not, I'll leave only the images with this size and another two for the desktop/menu button and readme. |
|
@Botspot The changes were merged. Next I'll fix the Youtube search and move the py2_version branch to master. |
Not sure what you mean |
|
I meant for the app store. I included three icon sizes there: 24x24, 48x48, 128x128. |
|
Oh don't worry. I have all the icon sizes I need. |
|
BTW, here's my app store: https://github.com/Botspot/pi-apps |
Cool, will have a look. Thank you for the link! :)
Yep, it's in my to-do list. |
|
@Botspot There it is: Fixed the youtube search feature, and added the icon to the window. |
|
Oh, and it's such a great idea that app of yours! |
|
I'll update this thread when I replace the master branch code. |
|
It's not working for me.
|
|
@Botspot DId you run the setup again? The new required lib can be installed with:
|
|
@Botspot there was a problem with this package installation in the setup script. That should be fixed now. |
|
Thank you one more time for all your help. |
|
Hey @Botspot , I think tkinter does not allow SVG for window icons, at least the python2 tkinter. But thank you, that may come in handy in the future. |
I understand that. But, a SVG comes in useful because SVGs aren't made up of pixels: instead they are vectors. So with a SVG image, you can export it to any size PNG you want, and the edges of the shapes will always stay clear. Let's say 5 years down the road: you may want a 1024x1024 icon, but I am long gone. With a SVG, it's really easy: just opent he SVG in Inkscape or an equivalent, and you have your 1024x1024 png image. Sending you the SVG ensures you can generate any icon size you want, without relying on me. Make sense? |
|
@Botspot OFC, that's why I said it might come in handy in the future. |

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.













I am developing a RPi app store and I plan to include this software.
When users click "install", the app store will then clone your repository and run your recommended install commands.
One problem though: it needs a unique icon. Does tboplayer have an icon? If not then I'll have to leave it blank.