The Wayback Machine - http://web.archive.org/web/20260329023428/https://github.com/github/opensource.guide/pull/1744
Skip to content

Improved ZH-Hans translate.#1744

Closed
ghost wants to merge 6 commits intomainfrom
unknown repository
Closed

Improved ZH-Hans translate.#1744
ghost wants to merge 6 commits intomainfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Aug 14, 2020 •
edited by ghost
Loading

Improved Simplified Chinese translate. Make the translation more accurate.

  • Have you followed the contributing guidelines?
    I followed the contributing guidelines.
  • Have you explained what your changes do, and why they add value to the Guides?
    Yes, I have.

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

Improved ZH-Hans translate.
8c80a31 
Improved Simplified Chinese translate.
@MikeMcQuaid
Copy link
Copy Markdown
Contributor

MikeMcQuaid commented Aug 14, 2020

Need to fix the failing CI tests on this PR.

@ghost ghost dismissed a stale review via b919e1b August 17, 2020 12:29
@moonhilal
Copy link
Copy Markdown

moonhilal commented Aug 18, 2020

I did ,t understand anything

@ghost ghost self-requested a review August 26, 2020 08:00
@iancanderson
Copy link
Copy Markdown
Contributor

iancanderson commented Aug 26, 2020 •
edited
Loading

Hi @zrzjohn - we can review this after you fix the errors in CI. For one thing, it looks like you auto-renamed pr to Pull Request, which resulted in some unintended changes, like renaming best-practices to best-Pull Requestactices

@iancanderson iancanderson requested review from a team and removed request for a team August 26, 2020 14:43
@ghost
Copy link
Copy Markdown
Author

ghost commented Aug 27, 2020 •
edited by ghost
Loading

Hi @zrzjohn - we can review this after you fix the errors in CI. For one thing, it looks like you auto-renamed pr to Pull Request, which resulted in some unintended changes, like renaming best-practices to best-Pull Requestactices

I don't know anything.

@ghost ghost closed this Aug 27, 2020
@ghost ghost reopened this Aug 27, 2020
MikeMcQuaid
MikeMcQuaid suggested changes Aug 28, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked on GitHub Actions CI job passing: https://github.com/github/opensource.guide/pull/1744/checks#step:7:38

Base automatically changed from master to main September 1, 2020 10:18
@ghost
Copy link
Copy Markdown
Author

ghost commented Sep 9, 2020

Need to fix the failing CI tests on this PR.

No GitHub API authentication could be found. Some fields may be missing or have incorrect data＄1¤7

agdgdh
agdgdh approved these changes Sep 14, 2020
View reviewed changes
Copy link
Copy Markdown

@agdgdh agdgdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Especially language bugs

This problems are human common issue.

redditblog
redditblog approved these changes Sep 15, 2020
View reviewed changes
_articles/zh-hans/building-community.md
@@ -27,10 +27,10 @@ redirect_from: /zh-cn/building-community/

Copy link
Copy Markdown

@redditblog redditblog Sep 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zrzjohn:master

@redditblog
Copy link
Copy Markdown

redditblog commented Sep 15, 2020

zrzjohn:master

@redditblog
Copy link
Copy Markdown

redditblog commented Sep 15, 2020

Blocked on GitHub Actions CI job passing: https://github.com/github/opensource.guide/pull/1744/checks#step:7:38

@redditblog
Copy link
Copy Markdown

redditblog commented Sep 15, 2020

Hi @zrzjohn - we can review this after you fix the errors in CI. For one thing, it looks like you auto-renamed pr to Pull Request, which resulted in some unintended changes, like renaming best-practices to best-Pull Requestactices

I don't know anything.

Anon79
Anon79 suggested changes Sep 16, 2020
View reviewed changes
Copy link
Copy Markdown

@Anon79 Anon79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anon79(ไ1¤7จ้าของ)

WillemJiang
WillemJiang suggested changes Oct 14, 2020
View reviewed changes
_articles/zh-hans/how-to-contribute.md
* 进行用户研究以重新计划和完善项目的导航或菜单
* 整理丄1¤7个风格指南，以帮助项目有丄1¤7致的视觉设计
* 创建t恤的艺术或一个新的标志，[就像 hapi.js 的贡献è„1¤7…那样](https://github.com/hapijs/contrib/issues/68)
* 创建t恤的艺术或一个新的标志，[就像 hapi.js 的贡献è„1¤7…那样](https://github.com/hapijs/contrib/Issues/68)
Copy link
Copy Markdown
Contributor

@WillemJiang WillemJiang Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change the url, as the new link is broken.
请保持原有的链接＄1¤7 新修改的链接是不能访问的〄1¤7

_articles/zh-hans/best-practices.md
title: 维护者最佳实跄1¤7
description: 身为弄1¤7源的维护者，如何轻松驾驭项目？本指南从文档流程到有效利用社区来展弄1¤7〄1¤7
class: best-practices
class: best-Pull Requestactices
Copy link
Copy Markdown
Contributor

@WillemJiang WillemJiang Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain why do you make this kind of change?

_articles/zh-hans/best-practices.md
### 保证交流是公弄1¤7进行的1¤7

不管是什么时候，保证你的交流是在公共的场扄1¤7（就是大家都能看到的地方）ã„1¤7‚如果有人尝试和你私聊，哪æ„1¤7•æ˜¯è®¨è®ºä¸„1¤7个新的需求或者功能，请礼貌的引导 Ta 到公共的交流场所，比如邮件列表或耄1¤7 issue tracker〄1¤7
不管是什么时候，保证你的交流是在公共的场扄1¤7（就是大家都能看到的地方）ã„1¤7‚如果有人尝试和你私聊，哪æ„1¤7•æ˜¯è®¨è®ºä¸„1¤7个新的需求或者功能，请礼貌的引导 Ta 到公共的交流场所，比如邮件列表或耄1¤7 Issue tracker〄1¤7
Copy link
Copy Markdown
Contributor

@WillemJiang WillemJiang Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't replace issue with Issue globally, as it just broke the old links of github issue.
请不要全文替捄1¤7 issue＄1¤7 这样会导臄1¤7 github issue链接失效〄1¤7

_articles/zh-hans/best-practices.md
你不霄1¤7要用超过 1-2 两句话来回复。比如，当一个[celery](https://github.com/celery/celery/)的用户报告了丄1¤7个window相关的错误，@berkerpeksag 是[这么](https://github.com/celery/celery/Issues/3383)回复的1¤7

![celery screenshot](/assets/images/best-practices/celery.png)
![celery screenshot](/assets/images/best-Pull Requestactices/celery.png)
Copy link
Copy Markdown
Contributor

@WillemJiang WillemJiang Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's just break the old link after the global replacement.

_articles/zh-hans/best-practices.md
如果别人认同项目的发展方向，给他们提交的权限或è„1¤7…正式把项目扄1¤7有权转移给他。如果有亄1¤7 fork 了你的项目è„1¤7Œä¸”在保持活跃的维护中，考虑在你的原始的仓库放上这个 fork 版本的链接ã„1¤7‚如果大家都希望你的项目继续的话这不失为丄1¤7种好办法〄1¤7

[@progruim](https://github.com/progrium) [发现](https://web.archive.org/web/20151204215958/https://progrium.com/blog/2015/12/04/leadership-guilt-and-pull-requests/) 由于它给他的项目[Dokku](https://github.com/dokku/dokku)写一个关于项目发展方向的文档，即使在它离弄1¤7这个项目后他的那些目标仍然会被实现ã„1¤7„1¤7
[@Pull Requestogruim](https://github.com/Pull Requestogrium) [发现](https://web.archive.org/web/20151204215958/https://Pull Requestogrium.com/blog/2015/12/04/leadership-guilt-and-pull-requests/) 由于它给他的项目[Dokku](https://github.com/dokku/dokku)写一个关于项目发展方向的文档，即使在它离弄1¤7这个项目后他的那些目标仍然会被实现ã„1¤7„1¤7
Copy link
Copy Markdown
Contributor

@WillemJiang WillemJiang Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just break lot of links.

@ghost ghost closed this Oct 15, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@MikeMcQuaid @moonhilal @iancanderson @redditblog @WillemJiang @041015778 @Anon79 @SaavyGirl @Loscello @agdgdh