The Wayback Machine - http://web.archive.org/web/20200906152917/https://github.com/topics/phpcs
Skip to content
#

phpcs

Here are 176 public repositories matching this topic...

jrfnl
jrfnl commented Jul 11, 2020

As per my comments in #1162:

  • Deprecated features should be a warning
  • Removed features should be an error
  • New features should be an error
  • For the few things which don't fall in the above categories: whether it is an error/warning should depend on how PHP handles the issue, i.e. does it cause a PHP parse/fatal error or a notice or warning to be thrown ?

Similarly for the error

VIP-Coding-Standards
mikeyarce
mikeyarce commented Jun 29, 2020

What problem would the enhancement address for VIP?

There's a potential issue with using target="_blank" and not using rel="noopener" or rel="noreferrer".
See: https://web.dev/external-anchors-use-rel-noopener/

Describe the solution you'd like

Maybe warn about this if we see noopener or noreferrer present?

What code should be reported as a violation?

`<a target="_

dd32
dd32 commented Jun 20, 2019

Issue Overview

When requesting a report for a specific version of a plugin, if Tide doesn't yet have a report for it it'll start to generate one and return a <p>pending</p> response.

That response then gets cached, and will return the <p>pending</p> response until it expires.
Suffixing a ?1 to the URL to bypass the URL caching then results in being able to access it.

Steps to R

staabm
staabm commented Feb 10, 2020

when cs2pr completes and no errors/warnings have to be emitted, the screen stays empty.

as a user I dont know whether everything worked well and nothing had to be reported or there was a error and I dont see it.

at best we could emit a processed x errors and y warnings or similar status message at the very end into STDERR, so we dont destory possible consumers of our gihtub-api checks

Improve this page

Add a description, image, and links to the phpcs topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the phpcs topic, visit your repo's landing page and select "manage topics."

Learn more

You can’t perform that action at this time.