The Wayback Machine - http://web.archive.org/web/20201004032030/https://github.com/dotnet/machinelearning/issues/4482
Skip to content

/ machinelearning

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usages of TPL DataFlow BufferBlock with Threading.Channels #4482

Open
eerhardt opened this issue Nov 15, 2019 · 7 comments
Open

Replace usages of TPL DataFlow BufferBlock with Threading.Channels #4482

eerhardt opened this issue Nov 15, 2019 · 7 comments
Labels
P2 good first issue up-for-grabs

Comments

@eerhardt
Copy link
Member

@eerhardt eerhardt commented Nov 15, 2019

There are 2 places we are using BufferBlock<T> today:

machinelearning/src/Microsoft.ML.Data/Transforms/RowShufflingTransformer.cs

Lines 486 to 487 in b7db4fa

private readonly BufferBlock<int> _toProduce;
private readonly BufferBlock<int> _toConsume;

machinelearning/src/Microsoft.ML.Sweeper/AsyncSweeper.cs

Line 171 in b7db4fa

private readonly BufferBlock<ParameterSetWithId> _paramQueue;

We should consider replacing this dependency with https://www.nuget.org/packages/System.Threading.Channels/ instead. Channels are a bit simpler, and more performant than BufferBlock.

See:

@eerhardt eerhardt mentioned this issue Nov 15, 2019

Merged
@mariombaltazar
Copy link

@mariombaltazar mariombaltazar commented Nov 25, 2019

I, Can I try do this?
@eerhardt
Copy link
Member Author

@eerhardt eerhardt commented Nov 25, 2019

@mariombaltazar -Yes! Feel free.
@mariombaltazar
Copy link

@mariombaltazar mariombaltazar commented Dec 3, 2019

I @eerhardt,
I can not do pull request. can you help me?
@eerhardt
Copy link
Member Author

@eerhardt eerhardt commented Dec 3, 2019

Here's the steps to create a pull request:

  1. Fork the repo - https://help.github.com/en/github/getting-started-with-github/fork-a-repo
  2. Push your changes to that fork
  3. Create the PR from your fork - https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork
@mstfbl mstfbl added the P2 label Jan 9, 2020
@mstfbl
Copy link
Member

@mstfbl mstfbl commented Jan 9, 2020

Hi @mariombaltazar , are you still interested in working on this issue?
@campiador
Copy link

@campiador campiador commented Feb 4, 2020 •
edited

@eerhardt @mstfbl Hi! In case this issue is available, may I please start working on it?
@antoniovs1029
Copy link
Member

@antoniovs1029 antoniovs1029 commented Feb 4, 2020

Hi @campiador . It is still an unsolved issue, and it seems that @mariombaltazar isn't working on it, so you can go for it 😃

@jwood803 jwood803 mentioned this issue May 13, 2020

Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 good first issue up-for-grabs
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
@harishsk @mariombaltazar @mstfbl @campiador @eerhardt @antoniovs1029
You can’t perform that action at this time.