The Wayback Machine - http://web.archive.org/web/20201013054558/https://github.com/dg/dibi/issues/291
Skip to content

/ dibi

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FirebirdDriver::escapeLike Dibi\NotImplementedException #291

Open
jan-oliva opened this issue Jun 7, 2018 · 8 comments
Open

FirebirdDriver::escapeLike Dibi\NotImplementedException #291

jan-oliva opened this issue Jun 7, 2018 · 8 comments

Comments

@jan-oliva
Copy link
Contributor

@jan-oliva jan-oliva commented Jun 7, 2018

Hello I have problem with firebird driver.
Firebird driver has not implemented escapeLike method.
Is possible to implement this method ?

Thanks
@dg
Copy link
Owner

@dg dg commented Jun 7, 2018

Can you try to do it and send a pull request?
@jan-oliva
Copy link
Contributor Author

@jan-oliva jan-oliva commented Jul 14, 2018

Pull request created
#300
@dg
Copy link
Owner

@dg dg commented Jul 14, 2018

Thanks
@jan-oliva
Copy link
Contributor Author

@jan-oliva jan-oliva commented Jul 16, 2018

Is possible propagate changes into tag v3.2.1 (v3.2.2) ?
Thanks
@dg
Copy link
Owner

@dg dg commented Jul 16, 2018

Are you sure that this solution is correct? According to http://www.janus-software.com/fbmanual/manual.php?book=psql&topic=82 If the escape clause is ommitted, then there is no default escape character..
@jan-oliva
Copy link
Contributor Author

@jan-oliva jan-oliva commented Aug 16, 2018

Do you mean
last_name LIKE '%A\_B%' ESCAPE '\'

New code
return ($pos <= 0 ? "'%" : "'") . $value . ($pos >= 0 ? "%'" : "'") .' ESCAPE '. "'\'";

returns string like LIKE '%Bašt%' ESCAPE ''

I will commit new code for pull request
@jan-oliva
Copy link
Contributor Author

@jan-oliva jan-oliva commented Aug 22, 2018

dle http://www.janus-software.com/fbmanual/manual.php?book=psql&topic=82 jsem to chápal, jako že když tam právě uvedu ESCAPE '', že tím právě definuji escape znak.
@dg
Copy link
Owner

@dg dg commented Aug 22, 2018

Asi jo, ale musí se to otestovat. Zkusil jsem přidat test. 0fb63f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@dg @jan-oliva
You can’t perform that action at this time.