GitHub Deployments Service Test schema missing variant #5389

calebcartwright · 2020-08-01T18:21:17Z

Apparently the latest deployment status can be null while there is a deployment in progress,

which we account for within the service class schema accordingly:

shields/services/github/github-deployments.service.js

Lines 28 to 32 in ea24784

    
           latestStatus: Joi.alternatives([ 
        
             Joi.object({ 
        
               state: isDeploymentState, 
        
             }), 
        
             null,

However, our service tests do not:

shields/services/github/github-deployments.tester.js

Lines 6 to 15 in ea24784

    
           const validMessages = [ 
        
             'success', 
        
             'error', 
        
             'failure', 
        
             'inactive', 
        
             'in progress', 
        
             'queued', 
        
             'pending', 
        
           ] 
        
           const isValidMessages = Joi.equal(...validMessages).required()

Ran into this earlier while trying to test a Dependabot PR while Dependabot/Repo Ranger were merging other PRs leading to shields-staging being deployed to during. I know this hasn't exactly been a frequent issue, but probably wouldn't hurt to make some tweaks, either by handling the null case more deliberately in the service class (for example, in what circumstance(s) does this occur and could we map the raw null to a more user-friendly badge message) or updating the service test validation schema

calebcartwright added the good first issue label Aug 1, 2020

calebcartwright mentioned this issue Aug 1, 2020

Build(deps): bump graphql-tag from 2.10.4 to 2.11.0, run [GitHubIssues GitHubHacktoberfest GitHubTag GitHubForks] #5378

Merged

calebcartwright added the hacktoberfest label Oct 2, 2020

Sep	OCT	Nov
	06
2019	2020	2021

badges / shields

GitHub Deployments Service Test schema missing variant #5389

GitHub Deployments Service Test schema missing variant #5389

calebcartwright commented Aug 1, 2020

badges / shields

Sponsor badges/shields

Join GitHub today

GitHub Deployments Service Test schema missing variant #5389

GitHub Deployments Service Test schema missing variant #5389

Comments

calebcartwright commented Aug 1, 2020

Essential cookies

Always active

Analytics cookies