The Wayback Machine - http://web.archive.org/web/20201017123607/https://github.com/OpenMined/PyDP/pull/308
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mypy support #308

Merged
merged 5 commits into from Oct 13, 2020
Merged

Added mypy support #308

merged 5 commits into from Oct 13, 2020

Conversation

@chinmayshah99
Copy link
Member

@chinmayshah99 chinmayshah99 commented Oct 11, 2020

Description

fixes #251

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • tests run locally

Checklist

@chinmayshah99
Copy link
Member Author

@chinmayshah99 chinmayshah99 commented Oct 11, 2020

The failed test shows that black doesn't work with py35. But since it's a development dependency, we are good to go :D

@chinmayshah99 chinmayshah99 merged commit 7062da2 into OpenMined:dev Oct 13, 2020
14 of 16 checks passed
14 of 16 checks passed
Build and publish (3.8)
Details
python-style-check (3.8)
Details
pytest (windows-2019, 3.5) pytest (windows-2019, 3.5)
Details
pytest (windows-2019, 3.6) pytest (windows-2019, 3.6)
Details
pytest (windows-2019, 3.7) pytest (windows-2019, 3.7)
Details
pytest (windows-2019, 3.8) pytest (windows-2019, 3.8)
Details
pytest (ubuntu-20.04, 3.5) pytest (ubuntu-20.04, 3.5)
Details
pytest (ubuntu-20.04, 3.6) pytest (ubuntu-20.04, 3.6)
Details
pytest (ubuntu-20.04, 3.7) pytest (ubuntu-20.04, 3.7)
Details
pytest (ubuntu-20.04, 3.8) pytest (ubuntu-20.04, 3.8)
Details
pytest (macOS-10.15, 3.5) pytest (macOS-10.15, 3.5)
Details
pytest (macOS-10.15, 3.6) pytest (macOS-10.15, 3.6)
Details
pytest (macOS-10.15, 3.7) pytest (macOS-10.15, 3.7)
Details
pytest (macOS-10.15, 3.8) pytest (macOS-10.15, 3.8)
Details
cpp-style-check (3.8)
Details
WIP Ready for review
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can’t perform that action at this time.