The Wayback Machine - http://web.archive.org/web/20201013055851/https://github.com/twitter/finagle/issues/526
Skip to content

/ finagle

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add com.twitter.finagle.zipkin.core.Endpoint.ipv6 #526

Open
adriancole opened this issue Jul 13, 2016 · 6 comments
Open

Add com.twitter.finagle.zipkin.core.Endpoint.ipv6 #526

adriancole opened this issue Jul 13, 2016 · 6 comments
Labels
good first issue

Comments

@adriancole
Copy link
Contributor

@adriancole adriancole commented Jul 13, 2016

We currently support logging of only IPv4 addresses. Starting with Zipkin 1.4, endpoints can omit IPv4 (by setting Endpoint.ipv4 to 0), and optionally log Endpoint.ipv6 as the raw 16byte address.
https://github.com/openzipkin/zipkin-api/blob/master/thrift/zipkinCore.thrift#L276

It looks like the most pivotal change is updating com.twitter.finagle.zipkin.core.Endpoint.ipv6

cc @sveinnfannar
@cryptoque
Copy link

@cryptoque cryptoque commented Mar 19, 2018

@adriancole @mosesn If no one is working on it, i would like to work on this issue.
@adriancole
Copy link
Contributor Author

@adriancole adriancole commented Mar 20, 2018

@mosesn
Copy link
Contributor

@mosesn mosesn commented Mar 29, 2018

@cryptoque 👍
@flostadler
Copy link

@flostadler flostadler commented Aug 5, 2019

@mosesn Are you still working on this? If not, I'd like to give it a try
@kevinoliver
Copy link
Member

@kevinoliver kevinoliver commented Aug 5, 2019

@flostadler it doesn't appear that anyone has been working on this. Please do give it a try.
@flostadler
Copy link

@flostadler flostadler commented Aug 6, 2019

@kevinoliver All right, I'm on it!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@adriancole @mosesn @kevinoliver @flostadler @cryptoque
You can’t perform that action at this time.