Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSet timeout for custom dialer. #1035
Conversation
|
|
||
| dialCtx = dctx | ||
| } | ||
|
|
methane
Nov 20, 2019
Member
Move this block into if ok { block.
Move this block into if ok { block.
zjj
Nov 20, 2019
•
Author
Contributor
updated, feeling something weird, It seems to have to move all them insied
updated, feeling something weird, It seems to have to move all them insied
| } else { | ||
| nd := net.Dialer{Timeout: mc.cfg.Timeout} | ||
| mc.netConn, err = nd.DialContext(ctx, mc.cfg.Net, mc.cfg.Addr) | ||
| mc.netConn, err = nd.DialContext(ctx, mc.cfg.Net, mc.cfg.Addr) // for DialContext shall be ctx, not dialCtx |
methane
Nov 20, 2019
Member
This comment is redundant.
This comment is redundant.
zjj
Nov 20, 2019
•
Author
Contributor
yes, this explains why the dialctx not passed to DialContext, for later puller could get some info.
if you can't accept this redundant comment, I would comit another patch to remove this comment.
remove ?
yes, this explains why the dialctx not passed to DialContext, for later puller could get some info.
if you can't accept this redundant comment, I would comit another patch to remove this comment.
remove ?
methane
Nov 20, 2019
Member
this explains why the dialctx not passed to DialContext, for later puller could get some info.
Read the comment. It doesn't explain why. And the code tells why cleary.
So this comment is just a noise. Please remove it.
this explains why the dialctx not passed to DialContext, for later puller could get some info.
Read the comment. It doesn't explain why. And the code tells why cleary.
So this comment is just a noise. Please remove it.
zjj
Nov 20, 2019
Author
Contributor
updated
updated
|
"Added myself / the copyright holder to the AUTHORS file" |
| @@ -86,6 +86,7 @@ Xiangyu Hu <xiangyu.hu at outlook.com> | |||
| Xiaobing Jiang <s7v7nislands at gmail.com> | |||
| Xiuming Chen <cc at cxm.cc> | |||
| Zhenye Xie <xiezhenye at gmail.com> | |||
| Jiajia Zhong <zhong2plus at gmail.com> | |||
methane
Nov 21, 2019
Member
See line 9:
# Please keep the list sorted.
See line 9:
# Please keep the list sorted.
zjj
Nov 21, 2019
Author
Contributor
thanks to your gude.
thanks to your gude.
methane
changed the title
Set timeout for custom dialer. (go-sql-driver#1035)
This reverts commit 15462c1.
Description
the dial ctx shall be something todo with the cfg.Timeout
Checklist