Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove error handling for export encoding #941
Conversation
sindresorhus
changed the title
|
@andreidobrinski To get this PR to pass the CI checks, we just need to remove the whitespace from the updated file. e.g.: From 7dc60d46521f7be77c022dc15c23ebde18ab33b4 Mon Sep 17 00:00:00 2001
From: Omitted <bots@scrape.this>
Date: Fri, 2 Oct 2020 08:33:28 -0400
Subject: [PATCH] style(whitespace): fix whitespace errors
breaking CI
See: https://app.circleci.com/pipelines/github/wulkano/Kap/168/workflows/047525cc-f95b-41aa-bf6e-be40c377aa7c/jobs/1721/parallel-runs/0/steps/0-103
---
main/utils/encoding.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/main/utils/encoding.js b/main/utils/encoding.js
index 3c48803..0307d57 100644
--- a/main/utils/encoding.js
+++ b/main/utils/encoding.js
@@ -15,11 +15,11 @@ const getEncoding = async filePath => {
await execa(ffmpegPath, ['-i', filePath]);
} catch (error) {
const errorText = /.*: Video: (.*?) \(.*/.exec(error.stderr);
-
+
if (!errorText) {
throw error;
}
-
+
return errorText[1];
}
};
--
2.27.0 |
|
Thanks @virtuoushub and @sindresorhus for the feedback. I updated the PR to remove whitespace. Thanks also for your work, I love the app! |
| if (!errorText) { | ||
| throw error; | ||
| } | ||
| return errorText[1]; |
virtuoushub
Oct 4, 2020
@andreidobrinski, almost there. Looking at the CI's error output, I believe the linter wants:
const errorText = /.*: Video: (.*?) \(.*/.exec(error.stderr);
if (!errorText) {
throw error;
}
return errorText[1];
We can use yarn test locally to verify.
@andreidobrinski, almost there. Looking at the CI's error output, I believe the linter wants:
const errorText = /.*: Video: (.*?) \(.*/.exec(error.stderr);
if (!errorText) {
throw error;
}
return errorText[1];We can use yarn test locally to verify.
andreidobrinski
Oct 4, 2020
Author
Thanks for the tip! I committed the update :)
Thanks for the tip! I committed the update :)
|
Still failing linting. Please always run |
|
Should be ok now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #888
Hope this helps!