The Wayback Machine - http://web.archive.org/web/20201003045406/https://github.com/apex/up/issues/774
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify a Minimum TLS Protocol Version for Custom Domains in API Gateway #774

Open
chatch opened this issue Jul 16, 2019 · 0 comments
Open

Specify a Minimum TLS Protocol Version for Custom Domains in API Gateway #774

chatch opened this issue Jul 16, 2019 · 0 comments

Comments

@chatch
Copy link

@chatch chatch commented Jul 16, 2019

Prerequisites

  • I am running the latest version. (up upgrade)
  • I searched to see if the issue already exists.
  • I inspected the verbose debug output with the -v, --verbose flag.
  • Are you an Up Pro subscriber?

Description

Currently the TLS version defaults to 1.0. I have to manually upgrade it to 1.2. So it would be nice if it could be specifed in the custom domain config in up.json.

Also consider changing the default to 1.2 instead of 1.0?

AWS docs for the setting are here:
https://docs.aws.amazon.com/apigateway/latest/developerguide/apigateway-custom-domain-tls-version.html

Steps to Reproduce

Deploy with a custom domain. Go to AWS console > API Gateway > custom domains and see the TLS version on the domain is 1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.