The Wayback Machine - http://web.archive.org/web/20201020194058/https://github.com/GoogleContainerTools/jib/issues/2764
Skip to content

/ jib

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable cyan coloring in build output when `--console=plain` is used. #2764

Open
mpeddada1 opened this issue Sep 16, 2020 · 1 comment
Open

Disable cyan coloring in build output when `--console=plain` is used. #2764

mpeddada1 opened this issue Sep 16, 2020 · 1 comment
Labels
good first issue

Comments

@mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Sep 16, 2020

No description provided.

@chanseokoh
Copy link
Member

@chanseokoh chanseokoh commented Sep 16, 2020

Affects both Maven and Gradle. Doesn't matter if it's --console=plain (Gradle), --batch-mode (-B) (Maven), or -Djib.console=plain.

We should also clean up code that we introduced in JibPluginTest to remove color sequence from a string.

String cleanOutput = output.replace("\u001B[36m", "").replace("\u001B[0m", "");

Details: #2739 (comment)

There may be more places where we color output.
mpeddada1 added a commit that referenced this issue Sep 16, 2020
@mpeddada1
Added TODO to remove cyan color filtering once #2764 is submitted.
Loading status checks…
4378bd3

@mpeddada1 mpeddada1 mentioned this issue Sep 16, 2020

Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@chanseokoh @mpeddada1
You can’t perform that action at this time.