deps: update V8 to 8.7 #35700

Stable release: Tue, Nov 17, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/33709/
~~V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/3482/~~
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/3484/ ✔️

Error on ARM64 Windows:

https://ci.nodejs.org/job/node-compile-windows/36659/nodes=win-vs2019-arm64/console

22:55:47   #
22:55:47   # Fatal error in , line 0
22:55:47   # Check failed: kFPParamRegisterCount == kParamRegisterCount.
22:55:47   #
22:55:47   #
22:55:47   #
22:55:47   #FailureMessage Object: 000000473CAB2890
22:55:47   ==== C stack trace ===============================
22:55:47   
22:55:47    v8::base::debug::StackTrace::StackTrace [0x00007FF63E43D54B+27] (C:\workspace\node-compile-windows\node\deps\v8\src\base\debug\stack_trace_win.cc:173)
22:55:47    v8::platform::`anonymous namespace'::PrintStackTrace [0x00007FF63DAE9261+17] (C:\workspace\node-compile-windows\node\deps\v8\src\libplatform\default-platform.cc:28)
22:55:47    V8_Fatal [0x00007FF63DADC532+162] (C:\workspace\node-compile-windows\node\deps\v8\src\base\logging.cc:166)
22:55:47    v8::internal::compiler::Linkage::GetSimplifiedCDescriptor [0x00007FF63DCCC414+340] (C:\workspace\node-compile-windows\node\deps\v8\src\compiler\c-linkage.cc:278)
22:55:47    v8::internal::compiler::`anonymous namespace'::CallCFunctionImpl [0x00007FF63DD268F4+324] (C:\workspace\node-compile-windows\node\deps\v8\src\compiler\raw-machine-assembler.cc:734)
22:55:47    v8::internal::compiler::RawMachineAssembler::CallCFunctionWithCallerSavedRegisters [0x00007FF63DD26A20+48] (C:\workspace\node-compile-windows\node\deps\v8\src\compiler\raw-machine-assembler.cc:769)
22:55:47    v8::internal::compiler::CodeAssembler::CallCFunctionWithCallerSavedRegisters [0x00007FF63DC56BC6+38] (C:\workspace\node-compile-windows\node\deps\v8\src\compiler\code-assembler.cc:1138)
22:55:47    v8::internal::RecordWriteCodeStubAssembler::CallCFunction2WithCallerSavedRegistersMode<v8::internal::Int32T,v8::internal::IntPtrT,v8::internal::IntPtrT> [0x00007FF63DECDB23+227] (C:\workspace\node-compile-windows\node\deps\v8\src\builtins\builtins-internal-gen.cc:193)
22:55:47    v8::internal::RecordWriteCodeStubAssembler::InsertIntoRememberedSetAndGoto [0x00007FF63DED2E84+708] (C:\workspace\node-compile-windows\node\deps\v8\src\builtins\builtins-internal-gen.cc:263)
22:55:47    v8::internal::RecordWriteAssembler::GenerateRecordWriteImpl [0x00007FF63DED0612+706] (C:\workspace\node-compile-windows\node\deps\v8\src\builtins\builtins-internal-gen.cc:360)
22:55:47    v8::internal::Builtins::Generate_RecordWrite [0x00007FF63DED1E94+100] (C:\workspace\node-compile-windows\node\deps\v8\src\builtins\builtins-internal-gen.cc:309)
22:55:47    v8::internal::`anonymous namespace'::BuildWithCodeStubAssemblerCS [0x00007FF63DEA38BF+223] (C:\workspace\node-compile-windows\node\deps\v8\src\builtins\setup-builtins-internal.cc:193)
22:55:47    v8::internal::SetupIsolateDelegate::SetupBuiltinsInternal [0x00007FF63DEA4578+120] (C:\workspace\node-compile-windows\node\deps\v8\src\builtins\setup-builtins-internal.cc:328)
22:55:47    v8::internal::Isolate::Init [0x00007FF63D589E95+1797] (C:\workspace\node-compile-windows\node\deps\v8\src\execution\isolate.cc:3561)
22:55:47    v8::SnapshotCreator::SnapshotCreator [0x00007FF63D498BE6+198] (C:\workspace\node-compile-windows\node\deps\v8\src\api\api.cc:624)
22:55:47    v8::internal::CreateSnapshotDataBlobInternal [0x00007FF63D5F25B1+65] (C:\workspace\node-compile-windows\node\deps\v8\src\snapshot\snapshot.cc:669)
22:55:47    main [0x00007FF63D491511+2449] (C:\workspace\node-compile-windows\node\deps\v8\src\snapshot\mksnapshot.cc:277)
22:55:47    __scrt_common_main_seh [0x00007FF63E3A8054+268] (D:\agent\_work\9\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
22:55:47    BaseThreadInitThunk [0x00007FFDBC981412+34]
22:55:47    RtlUserThreadStart [0x00007FFDBF3154F4+52]

Error in debug build:

See nodejs/node-v8#175

https://ci.nodejs.org/job/node-test-commit-linux-containered/22929/nodes=ubuntu1804_sharedlibs_debug_x64/console

00:35:09 #
00:35:09 # Fatal error in ../deps/v8/src/snapshot/context-serializer.cc, line 271
00:35:09 # Debug check failed: reference.is_back_reference().
00:35:09 #
00:35:09 #
00:35:09 #
00:35:09 #FailureMessage Object: 0x7ffc2b3cf9f0

@richard-townsend-arm

/cc @richard-townsend-arm (#35700 (comment))

Looks like it’s the same thing fixed in https://chromium-review.googlesource.com/c/v8/v8/+/2440717 Get Outlook for iOS<https://aka.ms/o0ukef>

…

________________________________ From: Michaël Zasso <notifications@github.com> Sent: Monday, October 19, 2020 9:23:27 AM To: nodejs/node <node@noreply.github.com> Cc: Richard Townsend <Richard.Townsend@arm.com>; Mention <mention@noreply.github.com> Subject: Re: [nodejs/node] deps: update V8 to 8.7 (#35700) /cc @richard-townsend-arm<https://github.com/richard-townsend-arm> (#35700 (comment)<#35700 (comment)>) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#35700 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHBU4RSCJBZE5CO235MIA4DSLPZP7ANCNFSM4SVKDFGA>. IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

Thanks! I cherry-picked that change.

Windows CI: https://ci.nodejs.org/job/node-test-commit-windows-fanned/38891/

Updated with the fix from nodejs/node-v8#175 (comment)

CI: https://ci.nodejs.org/job/node-test-pull-request/34358/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/3550/

CI: https://ci.nodejs.org/job/node-test-pull-request/34363/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/3554/

@joyeecheung

@joyeecheung it looks like there's another issue with mksnapshot in debug mode?

https://ci.nodejs.org/job/node-test-commit-linux-containered/23501/ seems to work fine other than test.parallel/test-fs-write-file (likely a flake), https://ci.nodejs.org/job/node-test-commit-linux-containered/23507/ failed with the ld killed with -9, it looks like a typical linker OOM issue which is pretty common in the CI. I started a rebuild here https://ci.nodejs.org/job/node-test-commit-linux-containered/23522/

CI: https://ci.nodejs.org/job/node-test-pull-request/34381/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/3557/

This should be ready. /cc @nodejs/v8-update @nodejs/tsc

Rubber-stamp LGTM if CI is green

Landed in 7991642...770d9e2

Jul	AUG	Sep
	29
2020	2021	2022

Learn and contribute

Connect with others

nodejs / node

deps: update V8 to 8.7 #35700

deps: update V8 to 8.7 #35700

targos commented Oct 18, 2020

nodejs-github-bot commented Oct 18, 2020 •

edited by targos

This comment has been hidden.

targos commented Oct 19, 2020

targos commented Oct 19, 2020

targos commented Oct 19, 2020

richard-townsend-arm commented Oct 19, 2020

targos commented Oct 19, 2020

targos commented Nov 12, 2020

nodejs-github-bot commented Nov 12, 2020 •

edited by targos

nodejs-github-bot commented Nov 12, 2020 •

edited by targos

targos commented Nov 12, 2020

joyeecheung commented Nov 13, 2020 •

edited

nodejs-github-bot commented Nov 13, 2020 •

edited by targos

targos commented Nov 13, 2020

Trott left a comment

targos commented Nov 15, 2020

nodejs / node

deps: update V8 to 8.7 #35700

deps: update V8 to 8.7 #35700

Conversation

targos commented Oct 18, 2020

nodejs-github-bot commented Oct 18, 2020 • edited by targos

This comment has been hidden.

targos commented Oct 19, 2020

targos commented Oct 19, 2020

targos commented Oct 19, 2020

richard-townsend-arm commented Oct 19, 2020

targos commented Oct 19, 2020

targos commented Nov 12, 2020

nodejs-github-bot commented Nov 12, 2020 • edited by targos

nodejs-github-bot commented Nov 12, 2020 • edited by targos

targos commented Nov 12, 2020

joyeecheung commented Nov 13, 2020 • edited

nodejs-github-bot commented Nov 13, 2020 • edited by targos

targos commented Nov 13, 2020

Trott left a comment

targos commented Nov 15, 2020

nodejs-github-bot commented Oct 18, 2020 •

edited by targos

nodejs-github-bot commented Nov 12, 2020 •

edited by targos

nodejs-github-bot commented Nov 12, 2020 •

edited by targos

joyeecheung commented Nov 13, 2020 •

edited

nodejs-github-bot commented Nov 13, 2020 •

edited by targos