The Wayback Machine - http://web.archive.org/web/20201021092213/https://github.com/topics/react-hooks
Skip to content
#

react-hooks

Here are 4,185 public repositories matching this topic...

formik
krichter722
krichter722 commented Apr 19, 2020

🚀 Feature request

Current Behavior

The type ErrorMessage doesn't have an id property.

Desired Behavior

It'd be nice id?: string would be added to the type ErrorMessage and set on the outermost component that serves as error message.

Suggested Solution

Add id={this.props.id} to the outer component in ErrorMessage.

Who does this impact? Who is this

beautiful-react-hooks
jacekk
jacekk commented Oct 3, 2020

Describe the bug
The following PR introduced some breaking change in typings: https://github.com/beautifulinteractions/beautiful-react-hooks/pull/156/files#diff-b52768974e6bc0faccb7d4b75b162c99R19

Argument of type '() => void' is not assignable to parameter of type 'any[]'.
  Type '() => void' is missing the following properties from type 'any[]': pop, push, concat, join, and 27 more
mpeyper
mpeyper commented Mar 19, 2019

There is an existing PR created to add docs to testing-library-docs from when testHook was part of react-testing-library. Since it was removed and the code merged with this library, the PR has stalled waiting on updates to change it to reference this library instead.

If anyone wants to take over the PR and update it accordingly, you are more than welcome. You can even [add yourself as a

taniarascia
taniarascia commented Oct 20, 2020

Problem
Right now, there are four sort strategies: title (alphabetical), date created, date modified, and favorites. I think favorites should not be in the list and should always be pinned to top.

Solution
Make only three sort strategies (alphabetical, modified, created) and always have favorites at the top of each section.

Notes
Will consider other options if there are othe

Improve this page

Add a description, image, and links to the react-hooks topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the react-hooks topic, visit your repo's landing page and select "manage topics."

Learn more

You can’t perform that action at this time.