The Wayback Machine - http://web.archive.org/web/20201023140439/https://github.com/nodejs/node/issues/35762
Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v15.0] NodeEventTarget#removeAllListeners has different return type than EventEmitter#removeAllListeners #35762

Open
Semigradsky opened this issue Oct 22, 2020 · 0 comments
Open

[v15.0] NodeEventTarget#removeAllListeners has different return type than EventEmitter#removeAllListeners #35762

Semigradsky opened this issue Oct 22, 2020 · 0 comments
Labels
events

Comments

@Semigradsky
Copy link

@Semigradsky Semigradsky commented Oct 22, 2020

NodeEventTarget:

node/lib/internal/event_target.js

Lines 473 to 479 in 3f4ec9c

removeAllListeners(type) {
if (type !== undefined) {
this[kEvents].delete(String(type));
} else {
this[kEvents].clear();
}
}

Looks like it should return this.

EventEmitter:

node/lib/events.js

Lines 515 to 559 in 3f4ec9c

EventEmitter.prototype.removeAllListeners =
function removeAllListeners(type) {
const events = this._events;
if (events === undefined)
return this;
// Not listening for removeListener, no need to emit
if (events.removeListener === undefined) {
if (arguments.length === 0) {
this._events = ObjectCreate(null);
this._eventsCount = 0;
} else if (events[type] !== undefined) {
if (--this._eventsCount === 0)
this._events = ObjectCreate(null);
else
delete events[type];
}
return this;
}
// Emit removeListener for all listeners on all events
if (arguments.length === 0) {
for (const key of ReflectOwnKeys(events)) {
if (key === 'removeListener') continue;
this.removeAllListeners(key);
}
this.removeAllListeners('removeListener');
this._events = ObjectCreate(null);
this._eventsCount = 0;
return this;
}
const listeners = events[type];
if (typeof listeners === 'function') {
this.removeListener(type, listeners);
} else if (listeners !== undefined) {
// LIFO order
for (let i = listeners.length - 1; i >= 0; i--) {
this.removeListener(type, listeners[i]);
}
}
return this;
};

@PoojaDurgad PoojaDurgad added the events label Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
events
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@Semigradsky @PoojaDurgad
You can’t perform that action at this time.