| Sep | OCT | Nov |
| 23 | ||
| 2019 | 2020 | 2021 |
COLLECTED BY
Collection: github.com
|
The WORKSPACE was updated to use node 12 in #16976 but the type checking was still using the types for node 12. The newer typings are a bit more precise but also bring in a return type overload for This updates existing references to node 10 to node 12, moves to the latest typings packages, selects node v12 types, and fixes type errors that arise from those changes.
For the error argument type change in |
e81d12eto395d1af
refactor: use node v12 types, matching WORKSPACE version
Loading status checks…
aa3961a
395d1aftoaa3961a
|
Does the build failure here mean that we'd need to land the new types in both the main repo and this one at the same time? |
Successfully merging this pull request may close these issues.
None yet
2 participants Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. ●© 2020 GitHub, Inc. ●Terms ●Privacy ● ●Security ●Status ●Help ●Contact GitHub ●Pricing ●API ●Training ●Blog ●About You can’t perform that action at this time. You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.