Returned type should be int not float #10

GreatBahram · 2019-11-01T17:52:53Z

Hello there,
I think, you should modify the type hints, since the xdist and ydist are both integer, so sum of them is going to be integer too, right?

ClassicComputerScienceProblemsInPython/Chapter2/maze.py

Lines 100 to 105 in 57d5f94

    
           def manhattan_distance(goal: MazeLocation) -> Callable[[MazeLocation], float]: 
        
               def distance(ml: MazeLocation) -> float: 
        
                   xdist: int = abs(ml.column - goal.column) 
        
                   ydist: int = abs(ml.row - goal.row) 
        
                   return (xdist + ydist) 
        
               return distance

davecom · 2019-11-22T00:46:56Z

Probably; we return float because we want consistency with Euclidean distance, and so that the type hints match with the heuristic parameter of astar(). The alternative is a float() conversion at the end of distance().

Thanks for pointing this out.

Oct	NOV	Dec
	01
2019	2020	2021

davecom / ClassicComputerScienceProblemsInPython

Returned type should be int not float #10

Returned type should be int not float #10

GreatBahram commented Nov 1, 2019

davecom commented Nov 22, 2019 •

edited

davecom / ClassicComputerScienceProblemsInPython

Join GitHub today

Returned type should be int not float #10

Returned type should be int not float #10

Comments

GreatBahram commented Nov 1, 2019

davecom commented Nov 22, 2019 • edited

Essential cookies

Always active

Analytics cookies

davecom commented Nov 22, 2019 •

edited