The Wayback Machine - http://web.archive.org/web/20201127210111/https://github.com/roots/sage-woocommerce/pull/20
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parantheses for nested ternary #20

Merged

Conversation

@kingkero
Copy link
Contributor

@kingkero kingkero commented Dec 9, 2019

PHP 7.4 deprecates using ternary operators without explicit parantheses, this PR will fix it and stop the extension from outputting notices.

@kingkero
Copy link
Contributor Author

@kingkero kingkero commented Dec 16, 2019

@mmirus @retlehs any problems with this?

@knowler knowler merged commit def4d3d into roots:master Jan 11, 2020
@knowler
Copy link
Member

@knowler knowler commented Jan 11, 2020

Thanks @kingkero!

@kingkero kingkero deleted the kingkero:feature/add-parantheses-to-nested-ternary branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.