The Wayback Machine - http://web.archive.org/web/20201114075521/https://github.com/nodejs/node/issues/36064
Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It should be impossible to construct an AbortSignal manually #36064

Open
benjamingr opened this issue Nov 10, 2020 · 1 comment · May be fixed by #36094
Open

It should be impossible to construct an AbortSignal manually #36064

benjamingr opened this issue Nov 10, 2020 · 1 comment · May be fixed by #36094
Labels
eventtarget good first issue

Comments

@benjamingr
Copy link
Member

@benjamingr benjamingr commented Nov 10, 2020

In AbortController/AbortSignal it is possible to construct an AbortSignal without a controller (but shouldn't be):

> var c = new AbortController();
> new c.signal.constructor()
AbortSignal { aborted: false }

Correct behavior:

> var c = new AbortController();
new c.signal.constructor()
TypeError: Illegal Constructor

This should be a relatively simple fix but it's a spec compliance issue - so if no new contributor picks this up I'll fix this sometime next week :]
@dev-script
Copy link
Contributor

@dev-script dev-script commented Nov 10, 2020

@benjamingr , I would like to work on this issue

@RaisinTen RaisinTen linked a pull request that will close this issue Nov 12, 2020

Open
3 of 3 tasks complete
RaisinTen added a commit to RaisinTen/node that referenced this issue Nov 12, 2020
@RaisinTen
events: disabled manual construction AbortSignal
26d163d 
Fixes: nodejs#36064
RaisinTen added a commit to RaisinTen/node that referenced this issue Nov 13, 2020
@RaisinTen
events: disabled manual construction AbortSignal
d353925 
Fixes: nodejs#36064
RaisinTen added a commit to RaisinTen/node that referenced this issue Nov 13, 2020
@RaisinTen
events: disabled manual construction AbortSignal
99dd10b 
Fixes: nodejs#36064
RaisinTen added a commit to RaisinTen/node that referenced this issue Nov 14, 2020
@RaisinTen
events: disabled manual construction AbortSignal
ef80268 
Fixes: nodejs#36064
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
eventtarget good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

events: disabled manual construction AbortSignal
2 participants
@benjamingr @dev-script
You can’t perform that action at this time.