The Wayback Machine - http://web.archive.org/web/20201012065740/https://github.com/github/docs/pull/204
Skip to content

/ docs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorg LICENSE files to be more discoverable #204

Merged
merged 2 commits into from Oct 7, 2020
Merged

Reorg LICENSE files to be more discoverable #204

merged 2 commits into from Oct 7, 2020
+411 −411

Conversation

@jeffmcaffer
Copy link
Contributor

@jeffmcaffer jeffmcaffer commented Oct 7, 2020

Why:

See #203

What's being changed:

Here we move the LICENSE files up to the root and identify the CC-BY-4.0 content license as the "primary" license (e.g., it is in the LICENSE file) since doc is the major role of the repo. Also updated the README and a couple tools that seem to treat license files specially.

Check off the following:
@jeffmcaffer
Reorg LICENSE files to be more discoverable
Loading status checks…
a17da38
@jeffmcaffer jeffmcaffer requested a review from github/docs-engineering as a code owner Oct 7, 2020
@deploy-to-heroku deploy-to-heroku bot temporarily deployed to docs-204--jmupdatelicense Oct 7, 2020 Inactive
@welcome
Copy link

@welcome welcome bot commented Oct 7, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.
@github-actions github-actions bot added this to Triage in Docs team reviews Oct 7, 2020
@jeffmcaffer
add missing )
Loading status checks…
f3a5bdc
@zeke
zeke approved these changes Oct 7, 2020
View changes
Copy link
Member

@zeke zeke left a comment

Nice 👍🏼
@zeke zeke merged commit 6da14f2 into main Oct 7, 2020
17 checks passed
17 checks passed
triage
Details
automerge
Details
automerge
Details
automerge
Details
automerge
Details
build
Details
build
Details
lint
Details
test
Details
test (content)
Details
test (meta)
Details
test (rendering)
Details
test (routing)
Details
test (unit)
Details
test (links-and-images)
Details
CodeQL Missing analysis for base commit be3a96561b6819eda2d73176763438446d9c3722
Details
staging deployed in 77 seconds
Details
@zeke zeke deleted the jm/updateLicense branch Oct 7, 2020
@github-actions
Copy link

@github-actions github-actions bot commented Oct 7, 2020

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. To add your ✨ contribution to the README.md, create a new comment in this PR with:

@all-contributors please add @jeffmcaffer for docs

If you want to, you can use the emoji key to replace docs with a different contribution type.
@allcontributors
Copy link
Contributor

@allcontributors allcontributors bot commented Oct 7, 2020

@github-actions[bot]

I could not determine your intention.

Basic usage: @all-contributors please add @Someone for code, doc and infra

For other usages see the documentation

@janiceilene janiceilene mentioned this pull request Oct 7, 2020

Closed
tnir added a commit to tnir/docs that referenced this pull request Oct 7, 2020
@jeffmcaffer @tnir
Reorg LICENSE files to be more discoverable (github#204)
4495f26 
* Reorg LICENSE files to be more discoverable

* add missing )

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>

@jeffmcaffer jeffmcaffer mentioned this pull request Oct 7, 2020

Closed

@mwichmann mwichmann mentioned this pull request Oct 8, 2020

Open
@jeffmcaffer
Copy link
Contributor Author

@jeffmcaffer jeffmcaffer commented Oct 8, 2020

@all-contributors please add @jeffmcaffer for docs

@allcontributors allcontributors bot mentioned this pull request Oct 8, 2020

Merged
@allcontributors
Copy link
Contributor

@allcontributors allcontributors bot commented Oct 8, 2020

@jeffmcaffer

I've put up a pull request to add @jeffmcaffer! 🎉
@janiceilene janiceilene moved this from Triage to Done in Docs team reviews Oct 9, 2020

@mlinksva mlinksva mentioned this pull request Oct 11, 2020

Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeke zeke

Assignees
No one assigned
Labels
None yet
Projects
Docs team reviews
Done
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@jeffmcaffer @zeke
You can’t perform that action at this time.