The Wayback Machine - http://web.archive.org/web/20201109183321/https://github.com/redux-saga/redux-saga/issues/1469
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitBooks #1469

Open
Andarist opened this issue Jun 4, 2018 · 6 comments
Open

Update GitBooks #1469

Andarist opened this issue Jun 4, 2018 · 6 comments

Comments

@Andarist
Copy link
Member

@Andarist Andarist commented Jun 4, 2018

I've noticed that redux' docs got a nice lifting, thanks for the new version of GitBook. Would be nice to upgrade too.

Redux commit introducing the change - reduxjs/redux@b307091

We might want to postpone merging this though, because we don't want to update docs before releasing v1 and from what I understand new Gitbook comes with auto-releases.

@shinima
Copy link
Collaborator

@shinima shinima commented Jun 4, 2018

I'm interested in working on this.

@divyanshu013
Copy link
Contributor

@divyanshu013 divyanshu013 commented Feb 13, 2019

I think this would be a good improvement to the docs. I followed the above pr, seems like there are issues with gitbook. Have you explored other options like docnasaurus or gatsby? Perhpas they could work well. Thoughts?

@Andarist
Copy link
Member Author

@Andarist Andarist commented Feb 26, 2019

@divyanshu013 they would certainly work well - but they would require quit a bit of work initially to setup, Im afraid that we don't have time resources to do that right now. Would you be willing to work on it? My personal choice out of those 2 would be gatsby

@divyanshu013
Copy link
Contributor

@divyanshu013 divyanshu013 commented Feb 27, 2019

@Andarist I also lean towards gatsby. I can surely pick it up but can't promise a timeline (apologies), if you're okay with it.

Any references for docs you have in mind? Gatsby themselves have a good docs site, for reference.

@Andarist
Copy link
Member Author

@Andarist Andarist commented Feb 27, 2019

@Andarist I also lean towards gatsby. I can surely pick it up but can't promise a timeline (apologies), if you're okay with it.

No problem, it's just an enhancement - we are not in a hurry :)

Any references for docs you have in mind? Gatsby themselves have a good docs site, for reference.

Not really - something rather standard, similar to what we currently have.

@divyanshu013
Copy link
Contributor

@divyanshu013 divyanshu013 commented Feb 27, 2019

Awesome, will keep you posted 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.