Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Fix #54 - implements CHildNodes in Node #55
Conversation
This comment has been minimized.
This comment has been minimized.
|
I'm confused, does this actually belong here? Adding it to CharacterData and DocumentType, keeping it on Element would make sense to me. Implementing at Node causes Document and Attr classes to have ChildNode functions where I don't think they should? My issue is fixed by this PR (thanks!) but I wanted to mention that it appears to implement ChildNode more widely than the specs and browsers. |
This comment has been minimized.
This comment has been minimized.
|
P.S. you have a point thought, this could land as CharacterData only thing, so I might change it right away. |
This comment has been minimized.
This comment has been minimized.
|
OK, CharacterData only extended, beside Element, so this should be OK now? |
This comment has been minimized.
This comment has been minimized.
|
Looks great, thanks for the fix. I would never call |
No description provided.