The Wayback Machine - http://web.archive.org/web/20260107122912/https://github.com/github/codeql/pull/4743
Skip to content

Java: Add flow steps through methods of java.nio.Buffer and its subclasses #4743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
joefarebrother wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Java: Add flow steps through methods of java.nio.Buffer and its subclasses #4743

joefarebrother wants to merge 3 commits into from

Conversation

@joefarebrother
Copy link
Contributor

@joefarebrother joefarebrother commented Nov 27, 2020

No description provided.

@joefarebrother joefarebrother requested a review from a team as a code owner November 27, 2020 16:25
@github-actions github-actions bot added the Java label Nov 30, 2020
@aschackmull
Copy link
Contributor

aschackmull commented Dec 2, 2020

LGTM, but we should run this through our usual differences job, just in case.

@joefarebrother
Copy link
Contributor Author

joefarebrother commented Dec 4, 2020 •
edited
Loading

https://jenkins.internal.semmle.com/job/Changes/job/Java-Differences/1067/
https://jenkins.internal.semmle.com/job/Changes/job/Java-Differences/1079/
https://jenkins.internal.semmle.com/job/Changes/job/Java-Differences/1085/

@Marcono1234
Copy link
Contributor

Marcono1234 commented Dec 13, 2020

Should CharBuffer.toString() be considered as well because it returns the content of the buffer?
Or should in general CharSequence.toString() (and other CharSequence methods) be considered by the taint analysis? It appears that is currently not the case.

@smowton
Copy link
Contributor

smowton commented Aug 11, 2021

@joefarebrother noticed this languishing; I assume Java-Differences was misbehaving? Throw it through the new DCA?

@bmuskalla
Copy link
Contributor

bmuskalla commented Sep 1, 2021

Given I'm working on related things anyway, I can take it over. Let me know if you want to keep it @joefarebrother

@bmuskalla bmuskalla self-assigned this Sep 1, 2021
@bmuskalla bmuskalla removed their assignment Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Java

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joefarebrother @aschackmull @Marcono1234 @smowton @bmuskalla