The Wayback Machine - http://web.archive.org/web/20201026112858/https://github.com/nodejs/node-inspect/issues/88
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.travis.yml references an EOL node version #88

Closed
dominykas opened this issue Aug 31, 2020 · 2 comments
Closed

.travis.yml references an EOL node version #88

dominykas opened this issue Aug 31, 2020 · 2 comments

Comments

@dominykas
Copy link
Member

@dominykas dominykas commented Aug 31, 2020

I was going through .travis.yml across the org to look for outdated Node.js versions and spotted this repo referencing 6.8. Does it need a bump?

Not sure what this is used for - is it meant to be testing in a single version? If so - might make sense to just change the version to lts/* or latest? If it's meant to test in multiple versions - it may be worth using one of the shared configs at https://github.com/nodejs/ci-config-travis to automatically include new versions?

Happy to PR, if needed.

@dominykas
Copy link
Member Author

@dominykas dominykas commented Aug 31, 2020

Also not sure what's the status of #21...

@jkrems
Copy link
Collaborator

@jkrems jkrems commented Aug 31, 2020

Thanks for bringing this up! I think the travis config could be deleted at this point, the repo was switched to Github workflows a while back.

dominykas added a commit to dominykas/node-inspect that referenced this issue Sep 22, 2020
Closes nodejs#88
@jkrems jkrems closed this in #91 Sep 22, 2020
jkrems pushed a commit that referenced this issue Sep 22, 2020
Closes #88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.