Please be sure to read the contributor's guide to the GitHub package before submitting any pull requests.

Requirements

• Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
• Suggestion: You can use checklists to keep track of progress for the sections on metrics, tests, documentation, and user research.

Description of the Change

Match electron-* dependencies to match Atom.

• Bump electron-link from 0.4.1 to 0.4.3
• Bump electron-mksnapshot to 9.0.2
  • This newer version of the electron-mksnapshot module allows specifying an exact Electron version you want to target, down to the patch level. I added a script/redownload-electron-bins.js file to set this env var when appropriate, and re-download (the correct version of) the Electron-vendored mksnapshot binary.

Screenshot/Gif

N/A

Alternate Designs

• We could just use electron-mksnapshot@6.0.0 and hope that it's similar enough to 6.1.12 to catch all the bugs we need to catch.

  • Pro: Less complexity in the repo. Simple.
  • Cons: Might not catch the same bugs? Hard to know. Also, the mksnapshot binaries on Linux are still huge for that release (~420-450 MB).

• When this github module is being installed as a dependency in the main Atom repo, the new script/redownload-electron-bins.js reads the main Atom repo's { package.json }.electronVersionand downloads the mksnapshot binary for that version of Electron.

  • Pro: Atom CI should now fail earlier on the GitHub package tests if an Electron bump breaks the GitHub module.
  • Con: This automatic behavior might be unexpected and confusing.

Let me know if you prefer the version of the Electron-vendored mksnapshot binary simply be hard-coded at this repo, and not dynamically set based on the parent Atom repo.

Benefits

Sync with Atom, catch all the bugs! 🎉

Much smaller (~1/10th as large) mksnapshot binary should save Linux users network bandwidth, hard-drive space, memory consumption...

Possible Drawbacks

script/redownload-electron-bins.js adds some complexity to the repo.

Applicable Issues

#2509

Metrics

N/A?

Tests

I am currently relying on the existing CI for validating this.

Documentation

N/A

Release Notes

N/A

User Experience Research (Optional)

N/A