I'm going to look into js-ast-utils/isBinary.ts now

I'm adding tests for js-ast-utils/isFor

I'm also adding tests for codec-source-map/ArraySet.ts

Should I start collapsing these posts into one and edit accordingly?

Sorry I didn't have time to review the list of tests in the issue body. We don't need tests for basic methods that are just refining types, they are extremely excessive and will be implicitly integration tested elsehwere.

@nt591 Feel free to batch them up into a single PR, whatever's easiest. If you're only adding new files then you shouldn't need to worry about merge conflcits at all! Thank you for doing this work!

Also when implementing any tests that operate on an AST, preferably inline the AST itself by manually constructing it with the create builder methods in @internal/ast, and if you really need to parse JS (such as a large example), use:

import {parseJS} from "@internal/js-parser";

parseJS({
  input: "CODE HERE",
  path: "unknown",
);

@nt591 and I started in on js-ast-utils/isUnaryLike.ts

Does the strikethrough mean it's one of the unneeded "basic methods that are just refining types" to be tested elsewhere?

We noticed throw is a JSThrowStatement not a UnaryExpression.

Yes the strikethrough means a test for it isn't needed.
I'll add that the the description.

They've been removed.

i'm going to look into js-ast-utils/isJsxElement

I will take
js-ast-utils/assertMultipleNodes.ts
js-ast-utils/assertSingleNode.ts
js-ast-utils/assertSingleOrMultipleNodes.ts
and try to batch them together bcz all of them looks fairly similar

@hanhanhan

We noticed throw is a JSThrowStatement not a UnaryExpression.

Oh that's really bizzare, that shouldn't be there... Want to open a PR to remove it? TypeScript checks should be enough to validate it's not used anywhere.

Thank you so much everyone for the PRs! I really appreciate it, especially since you've all written them without any context. I've long neglected tests for most of the code I've written since it's been a colossal effort to build it in the first place.

I think I will give a try to the things under js-ast-utils:

• markup-syntax-hightlight/index.ts
• parser-core/comments.ts
• parser-core/ParserCore.ts
• parser-core/utils.ts
• string-diff/index.ts
• vcs/index.ts

i will give a try at js-ast-utils/isFunctionNode

will try js-ast-utils/getJsxElementName as well

I'd like to take

js-ast-utils/tryStaticEvaluation.ts
js-ast-utils/tryStaticEvaluationPath.ts

@hanhanhan

We noticed throw is a JSThrowStatement not a UnaryExpression.

Oh that's really bizzare, that shouldn't be there... Want to open a PR to remove it? TypeScript checks should be enough to validate it's not used anywhere.

Here it is! #1138

I'll work on js-ast-utils/isNodeLike.ts.

I'll take js-ast-utils/isTypeNode.ts