liamdebeasi
Follow
Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign upPinned
1,171 contributions in the last year
Contribution activity
December 2020
Created 13 commits in 2 repositories
Created a pull request in ionic-team/ionic-framework that received 1 comment
fix(button): allow aria-label to be inherited to inner button
Pull request checklist Please check if your PR fulfills the following requirements: Tests for the changes have been added (for bug fixes / featu…
+6
−2
•
1
comment
Opened 12 other pull requests in 2 repositories
ionic-team/ionic-framework
9
merged
1
open
- 5.5.2
- Release 5.5.2
- fix(vue): correctly determine leaving view when transitioning to a new instance of a previous page
- chore(react): relax peer dependency requirements
- fix(vue): adding non tab button elements inside ion-tab-bar no longer causes errors
- fix(refresher): clean up old css if calling refresh method before native refresher is setup
- fix(refresher): refresher correctly detects native refresher when shown asynchronously
- fix(vue): correctly handle navigation failures
- fix(vue): query strings are now correctly handled when navigating back
- fix(vue): pass in correct route to props function
Reviewed 7 pull requests in 1 repository
ionic-team/ionic-framework 7 pull requests
- feat(slides): add container slot
- fix(refresher): refresher now correctly styled in dark mode
- test(item): fix disabled test script path
- fix(react): setting a ref should allow other props to be passed in, c…
- fix(progress-bar): use correct theme colors
- React Android Back Button Fixes
- fix(vue): pass in correct route to props function
Created an issue in ionic-team/ionic-framework that received 1 comment
bug: ionic vue non tab button elements in ion-tab-bar causes errors
ion-tab-bar expects all children to be ion-tab-button, but it's possible for a child to be a comment or other element. Right now it errors out sinc…
1
comment